-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fold "FrozenObjectHandle(REF) + CNS" to a byref constant #85888
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsLet's see if any target complains about it. This removes two "add" instructions from #85880 snippet, or e.g.: ReadOnlySpan<char> Test() => "Hello World" was: ; Method Program:Test():System.ReadOnlySpan`1[ushort]:this
mov rax, 0x14380209280 ; 'Hello World'
add rax, 12
mov edx, 11
ret
; Total bytes of code: 20 now: ; Method Program:Test():System.ReadOnlySpan`1[ushort]:this
mov rax, 0x29C8020928C
mov edx, 11
ret
; Total bytes of code: 16
|
This comment was marked as resolved.
This comment was marked as resolved.
/azp run runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-coreclr jitstressregs, runtime-coreclr gcstress0x3-gcstress0xc |
Azure Pipelines successfully started running 4 pipeline(s). |
/azp run runtime-coreclr outerloop, runtime-coreclr gcstress0x3-gcstress0xc |
Azure Pipelines successfully started running 2 pipeline(s). |
@dotnet/jit-contrib PTAL simple change with nice diffs, outerloop/jitstress/gcstress tests passed |
@jakobbotsch PTAL |
Let's see if any target complains about it. This removes two "add" instructions from #85880 snippet, or e.g.:
was:
now:
Diffs.