Capture remaining binding Bind & Get methods for source generator support #85843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue DetailsFixes #83600.
|
layomia
force-pushed
the
binder-gen-overloads
branch
from
d755857
to
d16382b
Compare
This was referenced May 9, 2023
layomia
force-pushed
the
binder-gen-overloads
branch
from
d16382b
to
0ec8d40
Compare
tarekgh
reviewed
May 10, 2023
...braries/Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingSourceGenerator.cs
Outdated
Show resolved
Hide resolved
tarekgh
reviewed
May 10, 2023
...Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingSourceGenerator.Emitter.cs
Outdated
Show resolved
Hide resolved
tarekgh
reviewed
May 10, 2023
...Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingSourceGenerator.Emitter.cs
Show resolved
Hide resolved
tarekgh
approved these changes
May 10, 2023
layomia
force-pushed
the
binder-gen-overloads
branch
from
db6c7d1
to
b912b13
Compare
layomia
force-pushed
the
binder-gen-overloads
branch
from
b912b13
to
bfb8cbb
Compare
layomia
changed the title
layomia
changed the title
layomia
added
the
source-generator
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #83600. Captures all
BindandGetoverloads onConfigurationBinderitself.Follow-up PRs:
ConfigurationBinder.GetValuemethods (Support ConfigurationBinder.GetValue in source-gen #86076)M.Extensions.Options-provided methods