Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][non-icu] HybridGlobalization set flag in SDK #85245

Merged
merged 11 commits into from
Jun 5, 2023
Merged

[browser][non-icu] HybridGlobalization set flag in SDK #85245

merged 11 commits into from
Jun 5, 2023

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Apr 24, 2023 •
edited
Loading

Implements a chunk of web-api based globalization. Is a part of HybridGlobalization feature and contributes to #79989.

PR that adds the browser-icu file should be merged first: dotnet/icu#300.

ToDo:

@ilonatommy ilonatommy self-assigned this Apr 24, 2023
@ghost
Copy link

ghost commented Apr 24, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Implements a chunk of web-api based globalization. Is a part of HybridGlobalization feature and contributes to #79989.

PR that adds the browser-icu file should be merged first: dotnet/icu#300.

This PR still needs WBT that can be added after the bullet point with sdk integration from #70762 will be solved.

Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-System.Globalization
Milestone: -

@build-analysis build-analysis bot mentioned this pull request May 11, 2023
Closed
@build-analysis build-analysis bot mentioned this pull request May 15, 2023
Closed
@ilonatommy
Copy link
Member Author

The new prebuilts after icu 72 bump are not loaded correctly
image
This PR cannot pass the CI without correct prebuilts propagation from icu repo.

This was referenced May 30, 2023
Closed
Open
@ilonatommy ilonatommy marked this pull request as ready for review June 4, 2023 18:13
@ilonatommy ilonatommy requested a review from maraf June 5, 2023 08:50
pavelsavara
pavelsavara reviewed Jun 5, 2023
View reviewed changes
Copy link
Member

@pavelsavara pavelsavara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When WasmBuildNative is also true, we could have more conditional compilation in C and C# and do more trimming of the unused code paths.

src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/BootJsonData.cs Outdated Show resolved Hide resolved
...nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets Outdated Show resolved Hide resolved
@ilonatommy
Copy link
Member Author

When WasmBuildNative is also true, we could have more conditional compilation in C and C# and do more trimming of the unused code paths.

After discussion, moving to the follow-up PR.

@ilonatommy ilonatommy merged commit 71dd370 into dotnet:main Jun 5, 2023
@ilonatommy ilonatommy mentioned this pull request Jun 6, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maraf maraf maraf left review comments

@pavelsavara pavelsavara pavelsavara approved these changes

@radical radical Awaiting requested review from radical

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@kg kg Awaiting requested review from kg

Assignees

@ilonatommy ilonatommy

Labels
arch-wasm WebAssembly architecture area-System.Globalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilonatommy @pavelsavara @maraf