-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release/7.0][PERF] Remove pipeline dependencies and steps for running Maui Mobile #85074
[Release/7.0][PERF] Remove pipeline dependencies and steps for running Maui Mobile #85074
Conversation
Remove references to Maui Android testing as the testing for it has moved to the performance repo.
…s been moved to the performance repo. (dotnet#84363)
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsRemove pipeline dependencies and steps for running Maui Mobile testing against net7.0 as they have been moved to the performance repo. Android: dotnet/performance#2789 iOS: dotnet/performance#2973. This is not vital to get in immediately, but the sooner the better.
|
@carlossanlop or @hoyosjs Can I get this added as something to merge whenever possible? It only makes changes to the test infrastructure. Thanks! |
Here is the perf infra test run succeeding in any parts that would be affected by this change: https://dev.azure.com/dnceng/internal/_build/results?buildId=2162725&view=results |
@LoopedBard3 the release/7.0 branch is currently closed for merging changes. We will reopen it on May 2nd, which is the date when we will do branding. Due to that restriction, we recently decided to create the release/7.0-staging and release/6.0-staging branches, which allow contributors get their PRs merged any time of the month, assuming they got Tactics approval, the CI passes (or the issues are confirmed to be unrelated) and got an area owner sign off. Also, those new branches don't need admins like Juan or I to merge PRs anymore. PR owners can do it, if they have runtime write permissions. Also, test-only changes and infrastructure-only changes (like yours) don't need Tactics approval. if you want this merged immediately, I suggest you retarget the PR to the release/7.0-staging branch. This makes sense since the staging branches are active right now, so they would benefit from your fix. The closed branches are currently inactive until we open them. Let me know if you have questions. Or if you don't have write permission, I can help merge your PR. |
@carlossanlop Changed the base branch from release/7.0 to release/7.0-staging. It looks like I don't have write permission so if you could help me out it would be greatly appreciated! Thank you. |
Gladly! |
@carlossanlop bump, this is ready from my end. 👍 |
@LoopedBard3 awesome. Just two more requests if you don't mind:
|
@carlossanlop Took a look at the PR changes and they all look correct/as expected. Took a look at the check failures, none of them looked related to any changes I made and there shouldn't be any since the changes only touch code that should be used by the Perf team testing pipeline. |
Great! Let's get this merged. |
Remove pipeline dependencies and steps for running Maui Mobile testing against net7.0 as they have been moved to the performance repo. Android: dotnet/performance#2789 iOS: dotnet/performance#2973.
This is not vital to get in immediately, but the sooner the better.