Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release/7.0][PERF] Remove pipeline dependencies and steps for running Maui Mobile #85074

Conversation

LoopedBard3
Copy link
Member

Remove pipeline dependencies and steps for running Maui Mobile testing against net7.0 as they have been moved to the performance repo. Android: dotnet/performance#2789 iOS: dotnet/performance#2973.

This is not vital to get in immediately, but the sooner the better.

@ghost
Copy link

ghost commented Apr 19, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Remove pipeline dependencies and steps for running Maui Mobile testing against net7.0 as they have been moved to the performance repo. Android: dotnet/performance#2789 iOS: dotnet/performance#2973.

This is not vital to get in immediately, but the sooner the better.

Author: LoopedBard3
Assignees: LoopedBard3
Labels:

area-Infrastructure

Milestone: -

@LoopedBard3
Copy link
Member Author

@carlossanlop or @hoyosjs Can I get this added as something to merge whenever possible? It only makes changes to the test infrastructure. Thanks!

@LoopedBard3
Copy link
Member Author

Here is the perf infra test run succeeding in any parts that would be affected by this change: https://dev.azure.com/dnceng/internal/_build/results?buildId=2162725&view=results

@carlossanlop
Copy link
Member

@LoopedBard3 the release/7.0 branch is currently closed for merging changes. We will reopen it on May 2nd, which is the date when we will do branding.

Due to that restriction, we recently decided to create the release/7.0-staging and release/6.0-staging branches, which allow contributors get their PRs merged any time of the month, assuming they got Tactics approval, the CI passes (or the issues are confirmed to be unrelated) and got an area owner sign off.

Also, those new branches don't need admins like Juan or I to merge PRs anymore. PR owners can do it, if they have runtime write permissions.

Also, test-only changes and infrastructure-only changes (like yours) don't need Tactics approval.

if you want this merged immediately, I suggest you retarget the PR to the release/7.0-staging branch. This makes sense since the staging branches are active right now, so they would benefit from your fix. The closed branches are currently inactive until we open them.

Let me know if you have questions. Or if you don't have write permission, I can help merge your PR.

@LoopedBard3 LoopedBard3 changed the base branch from release/7.0 to release/7.0-staging April 20, 2023 22:31
@LoopedBard3
Copy link
Member Author

@carlossanlop Changed the base branch from release/7.0 to release/7.0-staging. It looks like I don't have write permission so if you could help me out it would be greatly appreciated! Thank you.

@carlossanlop
Copy link
Member

Gladly!

@LoopedBard3
Copy link
Member Author

LoopedBard3 commented Apr 24, 2023

@carlossanlop bump, this is ready from my end. 👍

@carlossanlop
Copy link
Member

carlossanlop commented Apr 24, 2023

@LoopedBard3 awesome. Just two more requests if you don't mind:

  • Can you please confirm that retargeting to the new branch didn't unexpectedly bring any unrelated commits into your PR? It happens a lot ☹️.
  • Can you please confirm all the CI results are unrelated to your change?

@LoopedBard3
Copy link
Member Author

@carlossanlop Took a look at the PR changes and they all look correct/as expected. Took a look at the check failures, none of them looked related to any changes I made and there shouldn't be any since the changes only touch code that should be used by the Perf team testing pipeline.

@carlossanlop
Copy link
Member

Great! Let's get this merged.

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Apr 24, 2023
@carlossanlop carlossanlop merged commit f61192d into dotnet:release/7.0-staging Apr 24, 2023
@LoopedBard3 LoopedBard3 deleted the PerfRemoveMauiiOSPipelineSteps branch April 24, 2023 19:30
@ghost ghost locked as resolved and limited conversation to collaborators May 25, 2023
@LoopedBard3 LoopedBard3 changed the title [PERF] Remove pipeline dependencies and steps for running Maui Mobile [Release/7.0][PERF] Remove pipeline dependencies and steps for running Maui Mobile Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants