[mono][aot] Skip methods only in DEDUP_SKIP phase #85044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotlarmilos
requested review from
vargaz,
lambdageek and
SamMonoRT
as code owners
SamMonoRT
approved these changes
Apr 19, 2023
lambdageek
approved these changes
Apr 19, 2023
|
During the DEDUP_COLLECT phase, any method that is collected must be added to the |
|
Closing this PR. Will be introduced after the snap. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix dotnet/perf-autofiling-issues#16477. It reverts the the change that skip collected methods in DEDUP_COLLECT phase.