Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERF] Removed pipeline dependencies and steps for running Maui-iOS #84363

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 1 addition & 87 deletions eng/pipelines/coreclr/perf-non-wasm-jobs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -127,17 +127,14 @@ jobs:
runJobTemplate: /eng/pipelines/coreclr/templates/run-scenarios-job.yml
logicalmachine: 'perfpixel4a'

# run mono iOS scenarios and maui iOS scenarios
# run mono iOS scenarios scenarios
- template: /eng/pipelines/common/platform-matrix.yml
parameters:
jobTemplate: /eng/pipelines/coreclr/templates/perf-job.yml
buildConfig: release
runtimeFlavor: mono
platforms:
- osx_x64
variables:
- name: mauiVersion
value: $[ dependencies.Build_ios_arm64_release_MACiOSAndroidMauiNet7.outputs['getMauiVersion.mauiVersion'] ]
jobParameters:
testGroup: perf
runtimeType: iOSMono
Expand All @@ -146,7 +143,6 @@ jobs:
runJobTemplate: /eng/pipelines/coreclr/templates/run-scenarios-job.yml
logicalmachine: 'perfiphone12mini'
iOSLlvmBuild: False
additionalSetupParameters: "--mauiversion $(mauiVersion)"

- template: /eng/pipelines/common/platform-matrix.yml
parameters:
Expand All @@ -155,9 +151,6 @@ jobs:
runtimeFlavor: mono
platforms:
- osx_x64
variables:
- name: mauiVersion
value: $[ dependencies.Build_ios_arm64_release_MACiOSAndroidMauiNet7.outputs['getMauiVersion.mauiVersion'] ]
jobParameters:
testGroup: perf
runtimeType: iOSMono
Expand All @@ -166,28 +159,6 @@ jobs:
runJobTemplate: /eng/pipelines/coreclr/templates/run-scenarios-job.yml
logicalmachine: 'perfiphone12mini'
iOSLlvmBuild: True
additionalSetupParameters: "--mauiversion $(mauiVersion)"

# run maui iOS scenarios for net6 (Maui doesn't need Llmv true build (for net6))
- template: /eng/pipelines/common/platform-matrix.yml
parameters:
jobTemplate: /eng/pipelines/coreclr/templates/perf-job.yml
buildConfig: release
runtimeFlavor: mono
platforms:
- osx_x64
variables:
- name: mauiVersion
value: $[ dependencies.Build_ios_arm64_release_MACiOSAndroidMauiNet6.outputs['getMauiVersion.mauiVersion'] ]
jobParameters:
testGroup: perf
runtimeType: iOSMobileNet6
projectFile: ios_scenarios_net6.proj
runKind: ios_scenarios_net6
runJobTemplate: /eng/pipelines/coreclr/templates/run-scenarios-job.yml
logicalmachine: 'perfiphone12mini'
iOSLlvmBuild: False
additionalSetupParameters: "--mauiversion $(mauiVersion)"

# run mono microbenchmarks perf job
- template: /eng/pipelines/common/platform-matrix.yml
Expand Down Expand Up @@ -367,60 +338,3 @@ jobs:
# extraStepsTemplate: /eng/pipelines/common/upload-intermediate-artifacts-step.yml
# extraStepsParameters:
# name: MonoRuntimePacks

# build maui app net7.0
- template: /eng/pipelines/common/platform-matrix.yml
parameters:
jobTemplate: /eng/pipelines/common/global-build-job.yml
buildConfig: release
runtimeFlavor: mono
platforms:
- ios_arm64
jobParameters:
# Uncomment to reenable package replacement for main
#dependsOn:
# - Build_android_arm_release_Maui_Packs_Mono
# - Build_android_arm64_release_Maui_Packs_Mono
# - Build_android_x86_release_Maui_Packs_Mono
# - Build_android_x64_release_Maui_Packs_Mono
# - Build_maccatalyst_x64_release_Maui_Packs_Mono
# - Build_iossimulator_x64_release_Maui_Packs_Mono
# - Build_ios_arm64_release_Maui_Packs_Mono
buildArgs: -s mono -c $(_BuildConfig)
nameSuffix: MACiOSAndroidMauiNet7
isOfficialBuild: false
pool:
vmImage: 'macos-12'
extraStepsTemplate: /eng/pipelines/coreclr/templates/build-perf-maui-apps-net7.yml
extraStepsParameters:
rootFolder: '$(Build.SourcesDirectory)/artifacts/'
includeRootFolder: true
displayName: MAC, iOS, and Android Maui Artifacts Net7
artifactName: MACiOSAndroidMauiArmNet7
archiveExtension: '.tar.gz'
archiveType: tar
tarCompression: gz

# build maui app net6.0
- template: /eng/pipelines/common/platform-matrix.yml
parameters:
jobTemplate: /eng/pipelines/common/global-build-job.yml
buildConfig: release
runtimeFlavor: mono
platforms:
- ios_arm64
jobParameters:
buildArgs: -s mono -c $(_BuildConfig)
nameSuffix: MACiOSAndroidMauiNet6
isOfficialBuild: false
pool:
vmImage: 'macos-12'
extraStepsTemplate: /eng/pipelines/coreclr/templates/build-perf-maui-apps-net6.yml
extraStepsParameters:
rootFolder: '$(Build.SourcesDirectory)/artifacts/'
includeRootFolder: true
displayName: MAC, iOS, and Android Maui Artifacts Net6
artifactName: MACiOSAndroidMauiArmNet6
archiveExtension: '.tar.gz'
archiveType: tar
tarCompression: gz
90 changes: 6 additions & 84 deletions eng/pipelines/coreclr/templates/perf-job.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
# Test job depends on the corresponding build job
${{ if eq(parameters.downloadSpecificBuild.buildId, '') }}:
dependsOn:
- ${{ if not(in(parameters.runtimeType, 'AndroidMono', 'iOSMono', 'iOSMobileNet6', 'wasm')) }}:
- ${{ if not(in(parameters.runtimeType, 'AndroidMono', 'iOSMono', 'wasm')) }}:
- ${{ format('coreclr_{0}_product_build_{1}{2}_{3}_{4}', parameters.runtimeVariant, parameters.osGroup, parameters.osSubgroup, parameters.archType, parameters.buildConfig) }}
- ${{ if and(ne(parameters.liveLibrariesBuildConfig, ''), eq(parameters.skipLiveLibrariesDownload, 'false')) }}:
- ${{ format('libraries_build_{0}{1}_{2}_{3}', parameters.osGroup, parameters.osSubgroup, parameters.archType, parameters.liveLibrariesBuildConfig) }}
Expand All @@ -79,19 +79,15 @@ jobs:
- ${{ format('build_{0}{1}_{2}_{3}_{4}', parameters.osGroup, parameters.osSubgroup, parameters.archType, parameters.buildConfig, parameters.codeGenType) }}
- ${{ if eq(parameters.runtimeType, 'AndroidMono')}}:
- ${{ 'build_android_arm64_release_AndroidMono' }}
- ${{ 'Build_ios_arm64_release_MACiOSAndroidMauiNet7' }}
- ${{ if eq(parameters.runtimeType, 'iOSMono')}}:
- ${{ 'build_ios_arm64_release_iOSMono' }}
- ${{ 'Build_ios_arm64_release_MACiOSAndroidMauiNet7' }}
- ${{ if eq(parameters.runtimeType, 'iOSMobileNet6')}}:
- ${{ 'Build_ios_arm64_release_MACiOSAndroidMauiNet6' }}

${{ if and(eq(parameters.osGroup, 'windows'), not(in(parameters.runtimeType, 'AndroidMono', 'iOSMono', 'iOSMobileNet6'))) }}:
${{ if and(eq(parameters.osGroup, 'windows'), not(in(parameters.runtimeType, 'AndroidMono', 'iOSMono'))) }}:
${{ if eq(parameters.runtimeType, 'mono') }}:
extraSetupParameters: -Architecture ${{ parameters.archType }} -MonoDotnet $(Build.SourcesDirectory)\.dotnet-mono
${{ if eq(parameters.runtimeType, 'coreclr') }}:
extraSetupParameters: -CoreRootDirectory $(Build.SourcesDirectory)\artifacts\tests\coreclr\${{ parameters.osGroup }}.${{ parameters.archType }}.Release\Tests\Core_Root -Architecture ${{ parameters.archType }}
${{ if and(ne(parameters.osGroup, 'windows'), not(in(parameters.runtimeType, 'AndroidMono', 'iOSMono', 'iOSMobileNet6'))) }}:
${{ if and(ne(parameters.osGroup, 'windows'), not(in(parameters.runtimeType, 'AndroidMono', 'iOSMono'))) }}:
${{ if and(eq(parameters.runtimeType, 'mono'), ne(parameters.codeGenType, 'AOT')) }}:
extraSetupParameters: --architecture ${{ parameters.archType }} --monodotnet $(Build.SourcesDirectory)/.dotnet-mono
${{ if and(eq(parameters.runtimeType, 'wasm'), ne(parameters.codeGenType, 'AOT')) }}:
Expand All @@ -106,7 +102,7 @@ jobs:
extraSetupParameters: --corerootdirectory $(Build.SourcesDirectory)/artifacts/tests/coreclr/${{ parameters.osGroup }}.${{ parameters.archType }}.Release/Tests/Core_Root --architecture ${{ parameters.archType }} --alpine
${{ if in(parameters.runtimeType, 'AndroidMono') }}:
extraSetupParameters: -Architecture ${{ parameters.archType }} -AndroidMono
${{ if in(parameters.runtimeType, 'iosMono', 'iOSMobileNet6') }}:
${{ if in(parameters.runtimeType, 'iosMono') }}:
extraSetupParameters: --architecture ${{ parameters.archType }} --iosmono --iosllvmbuild ${{ parameters.iOSLlvmBuild }}

variables:
Expand Down Expand Up @@ -145,7 +141,7 @@ jobs:
displayName: 'live-built libraries'

# Download coreclr
- ${{ if not(in(parameters.runtimeType, 'AndroidMono', 'iOSMono', 'iOSMobileNet6', 'wasm')) }}:
- ${{ if not(in(parameters.runtimeType, 'AndroidMono', 'iOSMono', 'wasm')) }}:
- template: /eng/pipelines/common/download-artifact-step.yml
parameters:
unpackFolder: $(buildProductRootFolderPath)
Expand Down Expand Up @@ -213,7 +209,7 @@ jobs:
artifactName: 'AndroidMonoarm64'
displayName: 'Mono Android HelloWorld'

# Download iOSMono tests and MauiiOS/MacCatalyst
# Download iOSMono tests
- ${{ if eq(parameters.runtimeType, 'iOSMono') }}:
- template: /eng/pipelines/common/download-artifact-step.yml
parameters:
Expand Down Expand Up @@ -247,80 +243,6 @@ jobs:
downloadPath: '$(Build.SourcesDirectory)/iosHelloWorldZip/llvmzip'
artifactName: 'iOSSampleAppLLVM'
checkDownloadedFiles: true
- template: /eng/pipelines/common/download-artifact-step.yml
parameters:
unpackFolder: $(Build.SourcesDirectory)/MauiiOSDefaultIPA
cleanUnpackFolder: false
artifactFileName: 'MauiiOSDefaultIPA.tar.gz'
artifactName: 'MauiiOSDefaultIPA'
displayName: 'Maui iOS IPA'
- template: /eng/pipelines/common/download-artifact-step.yml
parameters:
unpackFolder: $(Build.SourcesDirectory)/MauiMacCatalystDefault
cleanUnpackFolder: false
artifactFileName: 'MauiMacCatalystDefault.tar.gz'
artifactName: 'MauiMacCatalystDefault'
displayName: 'Maui MacCatalyst App'
- template: /eng/pipelines/common/download-artifact-step.yml
parameters:
unpackFolder: $(Build.SourcesDirectory)/MauiiOSPodcastIPA
cleanUnpackFolder: false
artifactFileName: 'MauiiOSPodcastIPA.tar.gz'
artifactName: 'MauiiOSPodcastIPA'
displayName: 'Maui iOS Podcast IPA'
- template: /eng/pipelines/common/download-artifact-step.yml
parameters:
unpackFolder: $(Build.SourcesDirectory)/MauiBlazoriOSDefaultIPA
cleanUnpackFolder: false
artifactFileName: 'MauiBlazoriOSDefaultIPA.tar.gz'
artifactName: 'MauiBlazoriOSDefaultIPA'
displayName: 'Maui Blazor iOS IPA'
- template: /eng/pipelines/common/download-artifact-step.yml
parameters:
unpackFolder: $(Build.SourcesDirectory)/MauiBlazorMacCatalystDefault
cleanUnpackFolder: false
artifactFileName: 'MauiBlazorMacCatalystDefault.tar.gz'
artifactName: 'MauiBlazorMacCatalystDefault'
displayName: 'Maui Blazor MacCatalyst App'


# Download Maui iOS net6 stuff
- ${{ if eq(parameters.runtimeType, 'iOSMobileNet6') }}:
- template: /eng/pipelines/common/download-artifact-step.yml
parameters:
unpackFolder: $(Build.SourcesDirectory)/MauiiOSDefaultIPA
cleanUnpackFolder: false
artifactFileName: 'MauiiOSDefaultIPANet6.tar.gz'
artifactName: 'MauiiOSDefaultIPANet6'
displayName: 'Maui iOS IPA Net6'
- template: /eng/pipelines/common/download-artifact-step.yml
parameters:
unpackFolder: $(Build.SourcesDirectory)/MauiMacCatalystDefault
cleanUnpackFolder: false
artifactFileName: 'MauiMacCatalystDefaultNet6.tar.gz'
artifactName: 'MauiMacCatalystDefaultNet6'
displayName: 'Maui MacCatalyst App Net6'
- template: /eng/pipelines/common/download-artifact-step.yml
parameters:
unpackFolder: $(Build.SourcesDirectory)/MauiiOSPodcastIPA
cleanUnpackFolder: false
artifactFileName: 'MauiiOSPodcastIPANet6.tar.gz'
artifactName: 'MauiiOSPodcastIPANet6'
displayName: 'Maui iOS Podcast IPA Net6'
- template: /eng/pipelines/common/download-artifact-step.yml
parameters:
unpackFolder: $(Build.SourcesDirectory)/MauiBlazoriOSDefaultIPA
cleanUnpackFolder: false
artifactFileName: 'MauiBlazoriOSDefaultIPANet6.tar.gz'
artifactName: 'MauiBlazoriOSDefaultIPANet6'
displayName: 'Maui Blazor iOS IPA Net6'
- template: /eng/pipelines/common/download-artifact-step.yml
parameters:
unpackFolder: $(Build.SourcesDirectory)/MauiBlazorMacCatalystDefault
cleanUnpackFolder: false
artifactFileName: 'MauiBlazorMacCatalystDefaultNet6.tar.gz'
artifactName: 'MauiBlazorMacCatalystDefaultNet6'
displayName: 'Maui Blazor MacCatalyst App Net6'

# Create Core_Root
- script: $(Build.SourcesDirectory)/src/tests/build$(scriptExt) $(buildConfig) $(archType) generatelayoutonly $(librariesOverrideArg)
Expand Down
Loading