Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build on CBL-mariner host with rootfs #84148
Build on CBL-mariner host with rootfs #84148
Changes from 85 commits
8735c94
0084966
bb39763
a5f2dbd
db7bf3e
597a304
3e5a366
4c369f3
612c686
a9fd083
d0a1560
2abee9b
54dc641
2da99a9
825a1d9
c7468f6
ae6c6ab
3d70352
2f12a9a
f6bd3e5
e9f17fb
26621ab
39ca0c0
220094a
d4f71e9
d85c7d6
1b3afcb
938cdf1
749ee9c
6cb0b8e
96243bd
b84beba
c9137b3
d0d3312
ed0c013
2367f3f
a51dbde
76c434f
c30a214
dd59301
c4c5fa7
8a19475
8c41d41
a8cc38d
9aa3527
cd1f16a
143552e
04e6182
47246a3
7ecd081
405fbae
c1da152
9cd348b
d6b0649
8e12626
ecd4081
028a889
7fc39d3
6aa9f0a
667921b
cf0ffef
6c0b026
fc9c302
a5e22a0
09f6889
d23534a
609f19b
bedfad7
c708244
02ec629
e130eb5
0fcef90
f1ea8ad
04571e5
45bb34d
ee57442
d80a584
ddcd261
812d284
e25b5c9
0fe6ac6
8406c40
97a9faf
bfad4ea
018e961
1e2e056
ba6001c
92d1f22
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not in this PR, but can we consider moving this image to be based off Ubuntu 22.04 instead of Debian 11 (Debian 11 has an older CMake version than the one we want to use and IIRC I don't think we want to use the Kitware feed in our builds)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll give this a try.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we keeping the LLVMAOT build on the centos7 image? Same as the previous case?
Keeping this on CentOS 7 will delay some future infrastructure improvements in the repo (like upgrading CMake).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See description above - it's because the mono llvmaot test build depends on binutils (aot-compiler.c). I'd like to move this one over to the new images, but I'll ask @akoeplinger for guidance here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we consider moving this to the CentOS Stream 8 image? That will get us onto something supported and off of CentOS 7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll give this a try as well in a separate change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm yeah we should be able to pass in the clang tools instead of binutils (I know xamarin-android does this already), can you please file a separate issue so we can take a look at that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed #84700 to track this