Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[loader] Does find_method_in_class really see null method entries? #83335

Closed
wants to merge 1 commit into from

Conversation

lambdageek
Copy link
Member

@lambdageek lambdageek commented Mar 13, 2023

For hot reload it would be nice to rewrite this part of find_method_in_class using the mono_class_get_methods iterator. But the iterator contract is to return NULL when we're done iterating. So we might be changing something here.

Does modern code ever see NULL at this point? Apparently not. Assert that that is the case.

@ghost
Copy link

ghost commented Mar 13, 2023

Tagging subscribers to this area:
See info in area-owners.md if you want to be subscribed.

Issue Details

WIP hack. For hot reload it would be nice to rewrite this part of find_method_in_class using the mono_class_get_methods iterator. But the iterator contract is to return NULL when we're done iterating. So we might be changing something here.

Does modern code ever see NULL at this point?

Author: lambdageek
Assignees: lambdageek
Labels:

area-AssemblyLoader-mono

Milestone: -

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant