[loader] Does find_method_in_class really see null method entries? #83335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For hot reload it would be nice to rewrite this part of
find_method_in_class
using themono_class_get_methods
iterator. But the iterator contract is to returnNULL
when we're done iterating. So we might be changing something here.Does modern code ever see
NULL
at this point? Apparently not. Assert that that is the case.