[JIT] X86/X64 - Eliminate redundant 'cmp' instructions #82750
Conversation
…tructions are involved
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak |
src/coreclr/jit/emitxarch.cpp
Outdated
| emitPeepholeIterateLastInstrs([&](instrDesc* id) { | ||
| switch (id->idIns()) | ||
| { | ||
| case INS_seta: |
There was a problem hiding this comment.
I don't really want to specify specific instructions - I'm just doing this for now.
There was a problem hiding this comment.
Where did you get this list from?
There was a problem hiding this comment.
I'm just aware of the set and jmp instructions and we have the list defined in our instruction header file, so I just copied it from there.
|
@jakobbotsch it does look like they have redundant CMP, but I can't tell if this PR would eliminate them due to boundaries. It certainly wouldn't solve the issues if it did but it might help. |
…into redundant-cmp-opt
|
This PR is almost done, there appears to be a test failure specifically in linux 64 that I will need to reproduce locally to determine what is causing it. |
|
@dotnet/jit-contrib @BruceForstall This is ready; pending CI. |
Co-authored-by: Bruce Forstall <[email protected]>
Co-authored-by: Bruce Forstall <[email protected]>
Description
Resolves #70003
Replaces #81143
Acceptance Crtieria