[release/7.0] [browser] fix asset counting after download retry #82617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThis is simplified version of the https://github.com/dotnet/runtime/pull/81886/files Fixes #82271 Customer ImpactInternally detected problem on CI TestingManual testing RiskTBD
|
5 tasks
lewing
changed the title
lewing
added
Servicing-consider
ilonatommy
approved these changes
Feb 28, 2023
|
✅Manual tests work. |
maraf
approved these changes
Feb 28, 2023
This was referenced Feb 28, 2023
rbhanda
added
Servicing-approved
|
Approved by Tactics. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is simplified version of the https://github.com/dotnet/runtime/pull/81886/files
Fixes #82271
Customer Impact
Internally detected problem on CI.
The issue is caused by counting download retry multiple times.
Only when the retry is caused by download fail during
await response.arrayBuffer()but after HTTP headers are already fetched.That could be TCP failure and similar issues.
Testing
Added sample code with test for aborted HTTP stream and HTTP code 500 as well.
Manual testing
Risk
The download retry logic is complex.
This code path is relevant for WASM application which don’t use blazor (small audience).