Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][aot] Remove unused skip flag in the dedup #82471

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

kotlarmilos
Copy link
Member

This PR removes cfg->skip flag that is not used anymore during the deduplication. Current implementation uses dedup_methods hash table for storing extra methods which are emitted in a dedup AOT image. Previously, cfg->skip flag in dedup_skip_methods was used for indicating if a method should be emitted in an AOT image.

It depends on #82403 and contributes to #80419.

@kotlarmilos kotlarmilos added this to the 8.0.0 milestone Feb 22, 2023
@kotlarmilos kotlarmilos self-assigned this Feb 22, 2023
@kotlarmilos kotlarmilos marked this pull request as ready for review February 22, 2023 14:24
@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslike

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos
Copy link
Member Author

Failures shouldn't be related.

@kotlarmilos kotlarmilos merged commit 288cdc3 into dotnet:main Feb 22, 2023
@kotlarmilos kotlarmilos deleted the improvement/remove-skip-flag branch February 22, 2023 19:49
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants