Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono][wasm] Fix ldftn in AOT mode, it should return a ftndesc. #82282

Merged
merged 2 commits into from
Feb 21, 2023
Merged

[mono][wasm] Fix ldftn in AOT mode, it should return a ftndesc. #82282

merged 2 commits into from
Feb 21, 2023

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Feb 17, 2023

Fixes #82272.

@ghost ghost assigned vargaz Feb 17, 2023
@vargaz
Copy link
Contributor Author

vargaz commented Feb 17, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Feb 17, 2023
Closed
@maraf maraf mentioned this pull request Feb 17, 2023
Merged
@vargaz
Copy link
Contributor Author

vargaz commented Feb 17, 2023

Failures are relevant.

@vargaz vargaz marked this pull request as draft February 17, 2023 10:23
@vargaz
Copy link
Contributor Author

vargaz commented Feb 19, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vargaz vargaz marked this pull request as ready for review February 19, 2023 22:15
@vargaz
Copy link
Contributor Author

vargaz commented Feb 20, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@maraf
Copy link
Member

maraf commented Feb 20, 2023 •
edited
Loading

Can we enable tests disabled in #82285?

@vargaz
Copy link
Contributor Author

vargaz commented Feb 20, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Feb 20, 2023
Closed
@vargaz vargaz merged commit 75eac96 into dotnet:main Feb 21, 2023
@vargaz vargaz deleted the wasm-ldftn branch February 21, 2023 05:46
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing lewing approved these changes

@lambdageek lambdageek Awaiting requested review from lambdageek

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

Assignees

@vargaz vargaz

Labels
area-VM-meta-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[wasm] System.Reflection.Tests.MethodInfoTests.TestFunctionPointers failing with AOT on linux
3 participants
@vargaz @maraf @lewing