Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Add a RID for Fedora 39 #82208

Merged
merged 3 commits into from
Mar 9, 2023

Conversation

omajid
Copy link
Member

@omajid omajid commented Feb 15, 2023

This is a backport of #82185

I don't know why runtime.json has all these extra changes. Is this a platform-specific sorting issue?

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 15, 2023
@ghost
Copy link

ghost commented Feb 15, 2023

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

This is a backport of #82185

I don't know why runtime.json has all these extra changes. Is this a platform-specific sorting issue?

Author: omajid
Assignees: -
Labels:

area-Host

Milestone: -

@omajid omajid changed the title Add a RID for Fedora 39 [release/7.0] Add a RID for Fedora 39 Feb 15, 2023
@ghost
Copy link

ghost commented Mar 1, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

This is a backport of #82185

I don't know why runtime.json has all these extra changes. Is this a platform-specific sorting issue?

Author: omajid
Assignees: -
Labels:

area-Infrastructure-libraries, area-Host, community-contribution

Milestone: -

@carlossanlop
Copy link
Member

There was some discussion about the tooling here: #82185 (comment)

And if I'm not mistake, @ViktorHofer fixed the issue(s). So if you generated this PR using the latest version of the tool that include those fixes, the changes you see should be expected. Can you please help confirm @ViktorHofer / @wfurt ?

@ViktorHofer
Copy link
Member

ViktorHofer commented Mar 1, 2023

The additional changes are expected as some RIDs were manually added and @wfurt then run the tool which sorted them correctly.

Note that the tooling fix isn't yet backport into release/7.0. I just triggered it: #82851

@carlossanlop
Copy link
Member

@omajid Can you please update Microsoft.NETCore.Platorms.csproj as described here?:
https://github.com/dotnet/runtime/blob/release/7.0/docs/project/library-servicing.md

Need to set GeneratePackageOnBuild to true and increase the ServicingVersion number:

<ServicingVersion>1</ServicingVersion>
<GeneratePackageOnBuild>false</GeneratePackageOnBuild>

@wfurt do you mind reviewing this?

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs OOB changes.

@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Mar 8, 2023
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Mar 9, 2023
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OOB changes look good. Thanks @omajid.

@carlossanlop carlossanlop merged commit d7aa584 into dotnet:release/7.0 Mar 9, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 8, 2023
@agocke agocke removed the area-Host label Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-libraries community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants