Bump iOS/tvOS minimum version to 11.0, cleanup some code #81965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In .NET 8 the minimum Apple OS versions we're supporting are iOS/tvOS 11.0 and macOS 10.15. This bumps the version settings in various files and cleans up code that can now assume it's running on a later OS version. For example, it allows us to get rid of a couple `dlsym()` calls in System.Security.Cryptography.Native.Apple. We can also stop building the iOS arm and iOSSimulator x86 runtime packs since 32bit platforms aren't supported by iOS 11
akoeplinger
requested review from
radical,
lewing and
marek-safar
as code owners
marek-safar
reviewed
Feb 10, 2023
filipnavara
approved these changes
Feb 10, 2023
Comment on lines
+103
to
+104
| # getentropy isn't allowed in the AppStore: https://github.com/rust-lang/rust/issues/102643 | ||
| set(HAVE_GETENTROPY 0) |
There was a problem hiding this comment.
If it's not allowed on the AppStore then I think we should keep excluding it for macOS/tvOS too (even if macOS is not supported config for Mono anymore). Nevermind, I read the linked issue.
There was a problem hiding this comment.
Yeah one thing that might be confusing here is that HOST_IOS includes tvOS in the mono cmake build system. Longer term I'd like to unify differences like this with the rest of the repo.
marek-safar
approved these changes
Feb 13, 2023
akoeplinger
added a commit
to dotnet/icu
that referenced
this pull request
Feb 16, 2023
…rom tvOS We did the same in dotnet/runtime with dotnet/runtime#79349 and dotnet/runtime#81965
akoeplinger
added a commit
to dotnet/icu
that referenced
this pull request
Feb 16, 2023
…ode from tvOS (#318) * Bump iOS min version to 11, remove 32bit targets and remove bitcode from tvOS We did the same in dotnet/runtime with dotnet/runtime#79349 and dotnet/runtime#81965 * Fixup
This was referenced Feb 27, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In .NET 8 the minimum Apple OS versions we're supporting are iOS/tvOS 11.0 and macOS 10.15.
This bumps the version settings in various files and cleans up code that can now assume it's running on a later OS version. For example, it allows us to get rid of a couple
dlsym()calls in System.Security.Cryptography.Native.Apple.We can also stop building the iOS arm and iOSSimulator x86 runtime packs since 32bit platforms aren't supported by iOS 11