Allow root path for Microsoft.VisualBasic.FileIO.SpecialDirectories #81861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @cston |
This was referenced Feb 9, 2023
stephentoub
reviewed
Feb 9, 2023
| @@ -847,6 +847,27 @@ public void RenameFile_File_NewName() | |||
| // public void WriteAllText(string file, string text, bool append) { } | |||
| // public void WriteAllText(string file, string text, bool append, System.Text.Encoding encoding) { } | |||
|
|
|||
| /// <summary> | |||
There was a problem hiding this comment.
This PR currently only contains a new test. Did you intend to include a src fix as well?
There was a problem hiding this comment.
Yes, I wanted to verify the test hit the expected failures on osx and linux before making any src changes. I'll work on a fix next.
5 tasks
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
ghost
closed this
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #81544