-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix -Wformat violations #81618
Fix -Wformat violations #81618
Conversation
@@ -0,0 +1,25 @@ | |||
// Licensed to the .NET Foundation under one or more agreements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LakshanF This is the work I was alluding to regarding printf
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Failure appears to be known. |
#ifndef HAVE_MINIPAL_TYPES_H | ||
#define HAVE_MINIPAL_TYPES_H | ||
|
||
#if defined(TARGET_32BIT) || defined(TARGET_OSX) || defined(TARGET_WINDOWS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @lambdageek we can move these
runtime/src/mono/CMakeLists.txt
Lines 774 to 791 in 844f6ef
set(EGLIB_GSIZE_FORMAT "\"Iu\"") | |
else() | |
set(EGLIB_GSIZE_FORMAT "\"u\"") | |
endif() | |
else() | |
set(EGLIB_BREAKPOINT "G_STMT_START { raise(SIGTRAP); } G_STMT_END") | |
if(GCC) | |
set(EGLIB_GNUC_UNUSED "__attribute__((__unused__))") | |
set(EGLIB_GNUC_NORETURN "__attribute__((__noreturn__))") | |
if(HOST_AMD64 OR HOST_X86) | |
set(EGLIB_BREAKPOINT "G_STMT_START { __asm__(\"int \$03\"); } G_STMT_END") | |
endif() | |
endif() | |
set(EGLIB_PATHSEP "/") | |
set(EGLIB_SEARCHSEP ":") | |
set(EGLIB_OS "UNIX") | |
set(EGLIB_PIDTYPE "int") | |
set(EGLIB_GSIZE_FORMAT "\"zu\"") |
HOST_
vs. TARGET_
# TODO: remove the mono-style HOST_ variable checks once Mono is using eng/native/configureplatform.cmake to define the CLR_CMAKE_TARGET_ defines |
(I just realized that the macros in this file should be prefixed with MINIPAL_
for consistency)
Removes
-Wno-format
by defining formats in minipal/types.h and using it where it's needed to fix violations.