Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] [Android] Add NetworkChange implementation using PeriodicTimer (#80548) #81350

Conversation

simonrozsival
Copy link
Member

Backport of #80548 to release/7.0

Customer Impact

Several customers reported that they are unable to use the NetworkChange API in their MAUI apps. Due to a change in permissions in recent Android versions (12+), the previous implementation doesn't work anymore. Some customers will be able to use Xamarin.Essentials: Connectivity but for the rest, we provide a new implementation that will work with the Android permission restrictions.

Testing

Tested on a physical Android device and on Android emulators.

Risk

Low.

…t#80548)

* Add NetworkChange implementation using PeriodicTimer

* Code cleanup

* Rename functions

* Update csproj
@ghost
Copy link

ghost commented Jan 30, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #80548 to release/7.0

Customer Impact

Several customers reported that they are unable to use the NetworkChange API in their MAUI apps. Due to a change in permissions in recent Android versions (12+), the previous implementation doesn't work anymore. Some customers will be able to use Xamarin.Essentials: Connectivity but for the rest, we provide a new implementation that will work with the Android permission restrictions.

Testing

Tested on a physical Android device and on Android emulators.

Risk

Low.

Author: simonrozsival
Assignees: -
Labels:

area-System.Net

Milestone: -

@simonrozsival simonrozsival added NO-REVIEW Experimental/testing PR, do NOT review it Servicing-consider Issue for next servicing release review and removed NO-REVIEW Experimental/testing PR, do NOT review it labels Jan 30, 2023
@simonrozsival simonrozsival marked this pull request as ready for review February 3, 2023 14:57
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Feb 7, 2023
@rbhanda rbhanda added this to the 7.0.4 milestone Feb 7, 2023
@carlossanlop
Copy link
Member

Approved by Tactics for 7.0.4.
Signed-off by area owner.
No OOB changes needed for System.Net.NetworkInformation.
CI failures unrelated: #81544 #81123
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit 2964613 into dotnet:release/7.0 Feb 9, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants