Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GetAssemblyName test more robust. #80878

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Make GetAssemblyName test more robust. #80878

merged 1 commit into from
Jan 20, 2023

Conversation

VSadov
Copy link
Member

@VSadov VSadov commented Jan 19, 2023

Fixes: #80863

@ghost
Copy link

ghost commented Jan 19, 2023

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes: #80863

Author: VSadov
Assignees: -
Labels:

area-System.Reflection.Metadata

Milestone: -

@VSadov
Copy link
Member Author

VSadov commented Jan 19, 2023

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@VSadov
Copy link
Member Author

VSadov commented Jan 20, 2023

the android tests are failing, but I can't tell if this is the same failure or something else.

@VSadov
Copy link
Member Author

VSadov commented Jan 20, 2023

I will rebase and try running tests again.

@VSadov
Copy link
Member Author

VSadov commented Jan 20, 2023

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@simonrozsival
Copy link
Member

@VSadov the failing Android test StartupHookForFunctionalTest is unrelated (#80909)

@VSadov VSadov marked this pull request as ready for review January 20, 2023 23:37
@VSadov VSadov merged commit e13e738 into dotnet:main Jan 20, 2023
@VSadov VSadov deleted the testFix branch January 20, 2023 23:38
@VSadov
Copy link
Member Author

VSadov commented Jan 20, 2023

Thanks!

mdh1418 pushed a commit to mdh1418/runtime that referenced this pull request Jan 24, 2023
VSadov added a commit that referenced this pull request Jan 24, 2023
carlossanlop pushed a commit that referenced this pull request Feb 8, 2023
…y. (#81101)

* Set AssemblyName.ProcessorArchitecture for compatibility.

* Simplified ProcArch computation.

* Make GetAssemblyName test more robust (#80878)

* undo AssemblyName.CoreCLR change

* Library servicing steps.

---------

Co-authored-by: vsadov <[email protected]>
Co-authored-by: Vladimir Sadov <[email protected]>
@ghost ghost locked as resolved and limited conversation to collaborators Feb 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mono] System.Reflection.Metadata.Tests.MetadataReaderTests.GetAssemblyName is failing
2 participants