Fix ldarg_i test #79834
Fix ldarg_i test #79834
Conversation
janvorli
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsWhen changing the test recently, I have missed the conv.i4 that I should have removed from the preexisting code. The test was passing when
|
| @@ -24,7 +24,6 @@ | |||
| ldsflda int32 _ldarg::FOO | |||
| ldc.i4 0x2 | |||
| add | |||
| conv.i4 | |||
| ldsflda int32 _ldarg::FOO | |||
| call int32 _ldarg::args(int32) | |||
There was a problem hiding this comment.
I'm confused: the main branch contains:
call native int _ldarg::args(native int)
but GitHub is showing me the baseline of:
call int32 _ldarg::args(int32)
?
|
Note that you need to trigger outerloop tests if you want this test to actually run. |
When changing the test recently, I have missed the conv.i4 that I should have removed from the preexisting code. The test was passing when `runincontext` was passed to the coreclr test run, so I have incorrectly assumed that it will work in regular runs too.
janvorli
force-pushed
the
fix-ldarg-test
branch
from
f0a0ce9 to
893bb55
Compare
|
@BruceForstall I've accidentally made the change against an old main. I've just force pushed a fixed one. |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The pri-0 test build failed due to some nuget problem, but the outerloop test run succeeded, so I'm going to merge this. |
ghost
locked as resolved and limited conversation to collaborators
When changing the test recently, I have missed the conv.i4 that I should have removed from the preexisting code. The test was passing when
runincontextwas passed to the coreclr test run, so I have incorrectly assumed that it will work in regular runs too.