Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] Disable a few outerloop tests and update issue numbers #79759

Merged
merged 1 commit into from
Dec 17, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/libraries/System.Runtime/tests/System/GCTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ public static void LargeObjectHeapCompactionModeRoundTrips(GCLargeObjectHeapComp
}

[Theory]
[ActiveIssue("https://github.com/dotnet/runtime/issues/31657", TestRuntimes.Mono)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/73167", TestRuntimes.Mono)]
[InlineData(GCLatencyMode.Batch)]
[InlineData(GCLatencyMode.Interactive)]
// LowLatency does not roundtrip for server GC
Expand Down Expand Up @@ -458,6 +458,7 @@ public class GCExtendedTests
private const int NoGCRequestedBudget = 8192;

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/73167", TestRuntimes.Mono)]
[OuterLoop]
public static void GetGeneration_WeakReference()
{
Expand Down Expand Up @@ -508,6 +509,7 @@ public static void GCNotificationNegTests()
}

[ConditionalTheory(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/73167", TestRuntimes.Mono)]
[InlineData(true, -1)]
[InlineData(false, -1)]
[InlineData(true, 0)]
Expand All @@ -528,6 +530,7 @@ public static void GCNotificationTests(bool approach, int timeout)
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/73167", TestRuntimes.Mono)]
[OuterLoop]
public static void TryStartNoGCRegion_EndNoGCRegion_ThrowsInvalidOperationException()
{
Expand All @@ -550,6 +553,7 @@ private static void AllocateALot()
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/73167", TestRuntimes.Mono)]
[OuterLoop]
public static void TryStartNoGCRegion_ExitThroughAllocation()
{
Expand All @@ -568,6 +572,7 @@ public static void TryStartNoGCRegion_ExitThroughAllocation()
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/73167", TestRuntimes.Mono)]
[OuterLoop]
public static void TryStartNoGCRegion_StartWhileInNoGCRegion()
{
Expand All @@ -583,6 +588,7 @@ public static void TryStartNoGCRegion_StartWhileInNoGCRegion()
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/73167", TestRuntimes.Mono)]
[OuterLoop]
public static void TryStartNoGCRegion_StartWhileInNoGCRegion_BlockingCollection()
{
Expand All @@ -598,6 +604,7 @@ public static void TryStartNoGCRegion_StartWhileInNoGCRegion_BlockingCollection(
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/73167", TestRuntimes.Mono)]
[OuterLoop]
public static void TryStartNoGCRegion_StartWhileInNoGCRegion_LargeObjectHeapSize()
{
Expand All @@ -613,6 +620,7 @@ public static void TryStartNoGCRegion_StartWhileInNoGCRegion_LargeObjectHeapSize
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/73167", TestRuntimes.Mono)]
[OuterLoop]
public static void TryStartNoGCRegion_StartWhileInNoGCRegion_BlockingCollectionAndLOH()
{
Expand All @@ -628,6 +636,7 @@ public static void TryStartNoGCRegion_StartWhileInNoGCRegion_BlockingCollectionA
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/73167", TestRuntimes.Mono)]
[OuterLoop]
public static void TryStartNoGCRegion_SettingLatencyMode_ThrowsInvalidOperationException()
{
Expand All @@ -648,6 +657,7 @@ public static void TryStartNoGCRegion_SettingLatencyMode_ThrowsInvalidOperationE
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/73167", TestRuntimes.Mono)]
[OuterLoop]
public static void TryStartNoGCRegion_SOHSize()
{
Expand All @@ -662,6 +672,7 @@ public static void TryStartNoGCRegion_SOHSize()
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/73167", TestRuntimes.Mono)]
[OuterLoop]
public static void TryStartNoGCRegion_SOHSize_BlockingCollection()
{
Expand All @@ -676,6 +687,7 @@ public static void TryStartNoGCRegion_SOHSize_BlockingCollection()
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/73167", TestRuntimes.Mono)]
[OuterLoop]
public static void TryStartNoGCRegion_SOHSize_LOHSize()
{
Expand All @@ -690,6 +702,7 @@ public static void TryStartNoGCRegion_SOHSize_LOHSize()
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/73167", TestRuntimes.Mono)]
[OuterLoop]
public static void TryStartNoGCRegion_SOHSize_LOHSize_BlockingCollection()
{
Expand All @@ -704,6 +717,7 @@ public static void TryStartNoGCRegion_SOHSize_LOHSize_BlockingCollection()
}

[ConditionalTheory(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/73167", TestRuntimes.Mono)]
[OuterLoop]
[InlineData(0)]
[InlineData(-1)]
Expand All @@ -718,6 +732,7 @@ public static void TryStartNoGCRegion_TotalSizeOutOfRange(long size)
}

[ConditionalTheory(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/73167", TestRuntimes.Mono)]
[OuterLoop]
[InlineData(0)] // invalid because lohSize ==
[InlineData(-1)] // invalid because lohSize < 0
Expand Down Expand Up @@ -801,7 +816,7 @@ public static void GetAllocatedBytesForCurrentThread(int size)
private static bool IsNotArmProcessAndRemoteExecutorSupported => PlatformDetection.IsNotArmProcess && RemoteExecutor.IsSupported;

[ActiveIssue("https://github.com/dotnet/runtime/issues/64935", TestPlatforms.FreeBSD)]
[ActiveIssue("https://github.com/mono/mono/issues/15236", TestRuntimes.Mono)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/73167", TestRuntimes.Mono)]
[ConditionalFact(nameof(IsNotArmProcessAndRemoteExecutorSupported))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/29434")]
public static void GetGCMemoryInfo()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,8 @@ public void TestNullTarget_Completion()
DataflowBlock.NullTarget<int>().Completion);
}

[Fact]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsPreciseGcSupported))]
[OuterLoop] // finalizer/GC interactions
[ActiveIssue("https://github.com/dotnet/runtime/issues/46566", TestPlatforms.Browser)]
public void TestNullTarget_CompletionNoCaching()
{
// Make sure that the Completion task returned by a NullTarget
Expand Down Expand Up @@ -342,9 +341,8 @@ public async Task TestAsObservableAndAsObserver_AllObserversGetData()
Assert.Equal(expected: expectedTotal, actual: total);
}

[Fact]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsPreciseGcSupported))]
[OuterLoop] // stress test
[ActiveIssue("https://github.com/dotnet/runtime/issues/46566", TestPlatforms.Browser)]
public void TestAsObservableAndAsObserver_AsObservableDoesntLeak()
{
const int Count = 1000;
Expand Down