-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparation for JIT\Regression test merging - assembly/file renames #79489
Conversation
…ilenames and .assembly to match
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsTODO - fill in details
|
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
All failures are #79517 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you! I also love the way you modified the msbuild projects to refer to $(MSBuildProjectName)
instead of the particular test IL name, that's exactly the type of maintenance cost reduction cleanup the infra is all about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is a collection of renames that can be merged independently of actual test merging. It may be easier to look at each commit separately. I have them collected here in order to just do one PR process, but I can split them if needed. Automated changes were done with the ILTransform tool (started by @trylek, my version at https://github.com/markples/utils/tree/for-PR-dotnet-runtime-79489, commit 131b3764).
[ILTransform -p] Rename projects due to project name suffixes or proj…
[ILTransform -ilfile] Rename IL files and Includes to match…
[ILTransform -m] Remove .module from IL files
[ILTransform -a] Update .assembly to match filename in IL files
.assembly foo // as "foo"
- remove those comments too[ILTransform -n -a -ilfile] Deduplicate project names and update IL f…
Fix assembly reference in test dev11_132534
Fix assembly reference in test dev11_145295
Handwritten fixes to for IL->C# assembly references that were broken by the renames.