Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IDesignerSerializationManager nullability #79429

Merged
merged 3 commits into from
Dec 14, 2022
Merged

Fix IDesignerSerializationManager nullability #79429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4689efa
Add nullable annotation based off documentation
elachlan Dec 9, 2022
ccf1e41
changes from review
elachlan Dec 9, 2022
7e52c7e
further changes from review
elachlan Dec 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/libraries/System.ComponentModel.TypeConverter/ref/System.ComponentModel.TypeConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2192,11 +2192,11 @@ public partial interface IDesignerSerializationManager : System.IServiceProvider
event System.ComponentModel.Design.Serialization.ResolveNameEventHandler ResolveName;
event System.EventHandler SerializationComplete;
void AddSerializationProvider(System.ComponentModel.Design.Serialization.IDesignerSerializationProvider provider);
object CreateInstance(System.Type type, System.Collections.ICollection arguments, string name, bool addToContainer);
object GetInstance(string name);
string GetName(object value);
object GetSerializer(System.Type objectType, System.Type serializerType);
System.Type GetType(string typeName);
object CreateInstance(System.Type type, System.Collections.ICollection? arguments, string? name, bool addToContainer);
object? GetInstance(string name);
string? GetName(object value);
object? GetSerializer(System.Type? objectType, System.Type serializerType);
System.Type? GetType(string typeName);
void RemoveSerializationProvider(System.ComponentModel.Design.Serialization.IDesignerSerializationProvider provider);
void ReportError(object errorInformation);
void SetName(object instance, string name);
Expand Down
10 changes: 5 additions & 5 deletions ...Converter/src/System/ComponentModel/Design/Serialization/IDesignerSerializationManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,30 +71,30 @@ public interface IDesignerSerializationManager : IServiceProvider
/// of named instances. Objects that implement IComponent will be
/// added to the design time container if addToContainer is true.
/// </summary>
object CreateInstance(Type type, ICollection arguments, string name, bool addToContainer);
object CreateInstance(Type type, ICollection? arguments, string? name, bool addToContainer);
stephentoub marked this conversation as resolved.
Show resolved Hide resolved

/// <summary>
/// Retrieves an instance of a created object of the given name, or
/// null if that object does not exist.
/// </summary>
object GetInstance(string name);
object? GetInstance(string name);
elachlan marked this conversation as resolved.
Show resolved Hide resolved

/// <summary>
/// Retrieves a name for the specified object, or null if the object
/// has no name.
/// </summary>
string GetName(object value);
string? GetName(object value);
elachlan marked this conversation as resolved.
Show resolved Hide resolved

/// <summary>
/// Retrieves a serializer of the requested type for the given
/// object type.
/// </summary>
object GetSerializer(Type objectType, Type serializerType);
object? GetSerializer(Type? objectType, Type serializerType);

/// <summary>
/// Retrieves a type of the given name.
/// </summary>
Type GetType(string typeName);
Type? GetType(string typeName);

/// <summary>
/// Removes a previously added serialization provider.
Expand Down