Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/7.0] Update dependencies from dotnet/llvm-project #79273

Merged
merged 6 commits into from
Jan 12, 2023
Merged

[release/7.0] Update dependencies from dotnet/llvm-project #79273

merged 6 commits into from
Jan 12, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Dec 6, 2022 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/llvm-project

  • Subscription: dc7edec6-2e27-40ef-139c-08da7ef5fa55
  • Build: 20230111.4
  • Date Produced: January 12, 2023 1:16:15 AM UTC
  • Commit: 602a8ec539e0f9febb85bd4117ee5ff69265acd6
  • Branch: refs/heads/objwriter/release/7.0

@dotnet-maestro
Update dependencies from https://github.com/dotnet/llvm-project build…
a0602af 
… 20221205.4

runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx.11.0-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter
 From Version 1.0.0-alpha.1.22572.1 -> To Version 1.0.0-alpha.1.22605.4
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Dec 6, 2022
@dotnet-maestro
Update dependencies from https://github.com/dotnet/llvm-project build…
92dfe71 
… 20221205.4

runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx.11.0-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter
 From Version 1.0.0-alpha.1.22572.1 -> To Version 1.0.0-alpha.1.22605.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/llvm-project build…
9bd3892 
… 20221205.4

runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx.11.0-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter
 From Version 1.0.0-alpha.1.22572.1 -> To Version 1.0.0-alpha.1.22605.4
@build-analysis build-analysis bot mentioned this pull request Dec 14, 2022
Closed
@dotnet-maestro
Update dependencies from https://github.com/dotnet/llvm-project build…
1641005 
… 20221214.1

runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
 From Version 11.1.0-alpha.1.22578.2 -> To Version 11.1.0-alpha.1.22614.1
@runfoapp runfoapp bot mentioned this pull request Dec 15, 2022
Closed
@carlossanlop carlossanlop mentioned this pull request Jan 6, 2023
Closed
@carlossanlop carlossanlop reopened this Jan 9, 2023
@carlossanlop
Copy link
Member

carlossanlop commented Jan 11, 2023 •
edited
Loading

This PR is updating all the *MicrosoftNETCoreRuntimeObjWriterVersion and the CI has obj-writer failures. @MichalStrehovsky I noticed you've been consuming these properties (example). Can you please help investigate the failures?

Callstack example from one of the failures:

  System.DllNotFoundException: Unable to load DLL 'objwriter' or one of its dependencies: The specified module could not be found. (0x8007007E)
     at ILCompiler.DependencyAnalysis.ObjectWriter.InitObjWriter(String objectFilePath, String triple)
     at ILCompiler.DependencyAnalysis.ObjectWriter..ctor(String objectFilePath, NodeFactory factory, ObjectWritingOptions options) in /_/src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/ObjectWriter.cs:line 880
     at ILCompiler.DependencyAnalysis.ObjectWriter.EmitObject(String objectFilePath, IReadOnlyCollection`1 nodes, NodeFactory factory, ObjectWritingOptions options, IObjectDumper dumper, Logger logger) in /_/src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/ObjectWriter.cs:line 974
     at ILCompiler.RyuJitCompilation.CompileInternal(String outputFile, ObjectDumper dumper) in /_/src/coreclr/tools/aot/ILCompiler.RyuJit/Compiler/RyuJitCompilation.cs:line 103
     at ILCompiler.Compilation.ILCompiler.ICompilation.Compile(String outputFile, ObjectDumper dumper) in /_/src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Compilation.cs:line 528
     at ILCompiler.Program.Run(String[] args) in /_/src/coreclr/tools/aot/ILCompiler/Program.cs:line 958
     at ILCompiler.Program.Main(String[] args) in /_/src/coreclr/tools/aot/ILCompiler/Program.cs:line 1150
D:\a\_work\1\s\artifacts\bin\coreclr\windows.arm64.Release\build\Microsoft.NETCore.Native.targets(278,5): error MSB3073: The command ""D:\a\_work\1\s\artifacts\bin\coreclr\windows.arm64.Release\x64\ilc\\ilc" @"D:\a\_work\1\s\artifacts\obj\System.Runtime.Intrinsics.Tests\Release\net7.0-windows\native\System.Runtime.Intrinsics.Tests.ilc.rsp"" exited with code 1. [D:\a\_work\1\s\src\libraries\System.Runtime.Intrinsics\tests\System.Runtime.Intrinsics.Tests.csproj::TargetFramework=net7.0-windows]

@carlossanlop carlossanlop added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) blocked Issue/PR is blocked on something - see comments labels Jan 11, 2023
@MichalStrehovsky
Copy link
Member

This will be fixed by dotnet/llvm-project#334.

I postponed merging that because I wasn't sure it would be needed, but looks like it is. The build machine newly has ZLIB installed on Windows, LLVM build detects that and uses it, and then it fails everywhere because zlib.dll doesn't ship in Windows.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/llvm-project build…
c4c7bf9 
… 20230111.4

runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx.11.0-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter
 From Version 1.0.0-alpha.1.22572.1 -> To Version 1.0.0-alpha.1.23061.4
@build-analysis build-analysis bot mentioned this pull request Jan 12, 2023
Open
@carlossanlop
Copy link
Member

Seems the fix already flowed with the last commit. Thanks @MichalStrehovsky!
The new CI failures are unrelated:

@carlossanlop carlossanlop merged commit b84e2f6 into release/7.0 Jan 12, 2023
@carlossanlop carlossanlop deleted the darc-release/7.0-1aa376fb-796a-4a7c-aa6a-49e17ece0c50 branch January 12, 2023 21:19
@carlossanlop carlossanlop removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) blocked Issue/PR is blocked on something - see comments labels Jan 12, 2023
@carlossanlop carlossanlop mentioned this pull request Jan 12, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Feb 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlossanlop @MichalStrehovsky @radical