Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IndexOfAnyValues in Uri.EscapeString helper #79024

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

MihaZupan
Copy link
Member

Contributes to #78204 now that we have #78722

Method Toolchain Input Mean Error Ratio
EscapeDataString main AsciiNeedsEscaping 8,271.13 ns 51.813 ns 1.00
EscapeDataString pr AsciiNeedsEscaping 5,560.41 ns 10.109 ns 0.67
EscapeDataString main NothingToEscape 592.44 ns 3.579 ns 1.00
EscapeDataString pr NothingToEscape 67.00 ns 0.557 ns 0.11
EscapeDataString main Unicode 13,090.05 ns 102.756 ns 1.00
EscapeDataString pr Unicode 9,780.85 ns 19.247 ns 0.75

Things like NothingToEscape will of course improve even further with AVX2 support in IndexOfAnyAsciiSearcher #78863.

@MihaZupan MihaZupan added this to the 8.0.0 milestone Nov 30, 2022
@MihaZupan MihaZupan requested review from stephentoub and a team November 30, 2022 04:38
@ghost ghost assigned MihaZupan Nov 30, 2022
@ghost
Copy link

ghost commented Nov 30, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #78204 now that we have #78722

Method Toolchain Input Mean Error Ratio
EscapeDataString main AsciiNeedsEscaping 8,271.13 ns 51.813 ns 1.00
EscapeDataString pr AsciiNeedsEscaping 5,560.41 ns 10.109 ns 0.67
EscapeDataString main NothingToEscape 592.44 ns 3.579 ns 1.00
EscapeDataString pr NothingToEscape 67.00 ns 0.557 ns 0.11
EscapeDataString main Unicode 13,090.05 ns 102.756 ns 1.00
EscapeDataString pr Unicode 9,780.85 ns 19.247 ns 0.75

Things like NothingToEscape will of course improve even further with AVX2 support in IndexOfAnyAsciiSearcher #78863.

Author: MihaZupan
Assignees: -
Labels:

area-System.Net

Milestone: 8.0.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants