Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FMA tests to use Math.FusedMultiplyAdd for fallback #78672

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Nov 22, 2022

Fixes #78079

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 22, 2022
@ghost ghost assigned EgorBo Nov 22, 2022
@ghost
Copy link

ghost commented Nov 22, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #78079

Author: EgorBo
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@EgorBo
Copy link
Member Author

EgorBo commented Nov 22, 2022

/azp list

@azure-pipelines

This comment was marked as off-topic.

@EgorBo
Copy link
Member Author

EgorBo commented Nov 22, 2022

/azp run runtime-coreclr jitstress-isas-x86

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@EgorBo
Copy link
Member Author

EgorBo commented Nov 22, 2022

/azp run runtime-coreclr jitstress-isas-x86

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@EgorBo EgorBo marked this pull request as ready for review November 22, 2022 09:07
@EgorBo
Copy link
Member Author

EgorBo commented Nov 22, 2022

Failure is #76906

I've changed my mind around jitstress-isas since it takes up to 17h and is currently red (thanks @jakobbotsch for pointing that out) and these changes are already validated on CI as part of the inner loop. Merging to unblock ci

@EgorBo EgorBo merged commit 7368079 into dotnet:main Nov 22, 2022
@EgorBo EgorBo deleted the fix-fma-hw-tests branch November 22, 2022 10:33
@ghost ghost locked as resolved and limited conversation to collaborators Dec 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JIT.HardwareIntrinsics.X86._Fma_Vector256.Program.MultiplyAddSingle fails in consolidated Vector test on OSX
2 participants