Remove invalidation of whitespace in TryGetNextExtendedAttribute #78465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-io |
stephentoub
commented
Nov 16, 2022
...ibraries/System.Formats.Tar/tests/TarReader/TarReader.File.GlobalExtendedAttributes.Tests.cs
Show resolved
Hide resolved
...ibraries/System.Formats.Tar/tests/TarReader/TarReader.File.GlobalExtendedAttributes.Tests.cs
Show resolved
Hide resolved
carlossanlop
approved these changes
Nov 16, 2022
jozkee
approved these changes
Nov 16, 2022
|
I've added the test @carlossanlop requested. I have not changed the existing starting whitespace trimming behavior. @carlossanlop, can you please follow-up on that if it should be revisited? Also, should we be looking at backporting this to release/7.0? |
|
It's not explicitly mentioned in the spec, so I agree that we should remove the trim call, especially since Yes, we can backport it all together, especially if we include the removal of the trim call. |
carlossanlop
pushed a commit
to carlossanlop/runtime
that referenced
this pull request
Nov 23, 2022
…net#78465) * Remove invalidation of whitespace in TryGetNextExtendedAttribute * Add requested test
carlossanlop
added a commit
that referenced
this pull request
Nov 29, 2022
…attributes (#78785) * Remove invalidation of whitespace in TryGetNextExtendedAttribute (#78465) * Remove invalidation of whitespace in TryGetNextExtendedAttribute * Add requested test * Remove TrimStart in PAX extended attributes (#78707) * Remove TrimStart in PAX extended attributes * Adjust existing tests with two extra inline datas. Co-authored-by: carlossanlop <[email protected]> * Tar: Extra tests to confirm extra long paths are not treated as duplicate entries when the full path is in the extended attributes. (#78744) Co-authored-by: carlossanlop <[email protected]> Co-authored-by: Stephen Toub <[email protected]> Co-authored-by: carlossanlop <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#78456