[Release/6.0][PERF] Fix perf repo branch setup target, tool build, and mono-dotnet create #78411
Conversation
…e perf branch to be used to release/6.0.
…/mono-dotnet to use the product version properly.
…ues do currently need to be hardcoded.
… without it and hardcode the product version as we can't use the property product version in the create mono dotnet yaml.
|
Tagging subscribers to this area: @hoyosjs Issue DetailsThis PR only makes changes to performance testing infrastructure, not to any runtime code. This fixes multiple issues currently affecting the Release6.0 branch perf testing. This includes setting the perf repo branch to be downloaded to release/6.0 as main now contains some tests that are incompatible with net6.0, updating tools to build for net6.0 and disabling the builds download of transitive frameworks to ensure we don't hit issues when a new app ref is referenced but not released, and updated the mono-dotnet step to use the current product version properly. A mostly successful test run is available here: https://dev.azure.com/dnceng/internal/_build/results?buildId=2045554&view=results (much more successful than current state).
|
LoopedBard3
changed the title
|
@carlossanlop or @hoyosjs Can I get this merged? There is only one failure and this PR doesn't change anything outside of performance testing flow. Thanks! |
|
@carlossanlop you're more familiar with branch dates. This should likely just be tell mode |
|
@LoopedBard3 is this issue blocking you somewhere? If there's no urgency, let's wait until the branch reopens for servicing changes on Nov. 29th. |
|
This should be alright to wait until then since the performance tests only run when new updates are made to the release/6.0 runtime branch, and I am assuming there are not going to be a bunch of updates merging before the 29th. |
This comment was marked as outdated.
This comment was marked as outdated.
|
Nevermind, I see you already validated:
|
|
Tagging subscribers to this area: @directhex Issue DetailsThis PR only makes changes to performance testing infrastructure, not to any runtime code. This fixes multiple issues currently affecting the Release6.0 branch perf testing. This includes setting the perf repo branch to be downloaded to release/6.0 as main now contains some tests that are incompatible with net6.0, updating tools to build for net6.0 and disabling the builds download of transitive frameworks to ensure we don't hit issues when a new app ref is referenced but not released, and updated the mono-dotnet step to use the current product version properly. A mostly successful test run is available here: https://dev.azure.com/dnceng/internal/_build/results?buildId=2045554&view=results (much more successful than current state). Fixes: dotnet/performance#2711 and part of dotnet/performance#2719
|
|
Temporarily converting to draft to test proj file based version retrieval. |
…tting it using add_properties_to_pipeline.proj file.
This reverts commit 0fd4cc5.
|
@LoopedBard3 the branch is open for merging. How is this looking? Do we want it in 6.0.13 (Jan) or should we defer it to 6.0.14 (Feb)? |
|
@carlossanlop I am about to push the final cleanup change for merging, it mostly consists of the same changes as the other branch changes so should be good. The earlier we can get it in, the better. |
|
Final push is up and have a run going here: https://dev.azure.com/dnceng/internal/_build/results?buildId=2056152&view=results |
|
@LoopedBard3 can you please take a look at the CI results and let me know if this is good to merge? |
|
This fixed a good chunk of the issues currently occurring in the release/6.0 pipeline and is good to merge. |
ghost
locked as resolved and limited conversation to collaborators
This PR only makes changes to performance testing infrastructure, not to any runtime code.
This fixes multiple issues currently affecting the Release6.0 branch perf testing. This includes setting the perf repo branch to be downloaded to release/6.0 as main now contains some tests that are incompatible with net6.0, updating tools to build for net6.0 and disabling the builds download of transitive frameworks to ensure we don't hit issues when a new app ref is referenced but not released, and updated the mono-dotnet step to use the current product version properly.
A mostly successful test run is available here: https://dev.azure.com/dnceng/internal/_build/results?buildId=2045554&view=results (much more successful than current state).
Fixes: dotnet/performance#2711 and part of dotnet/performance#2719