-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use TaskDialog for error dialog in Windows GUI apps #78087
Conversation
Adding @mairaw - this is one of the common ways to get to the website. Maybe there's opportunity to provide consistent UX and terminology. I think we can design the default dialog content to be "End user friendly" and then include the technical details in the collapsed drop down section of the dialog. Nit: (I noticed this with our current dialog as well) - the dialog doesn't have the standard "Red X" close button in the top right corner. I think ideally it should have that. |
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsShow runtime/framework not found error via a task dialog instead of a message box when possible - falls back to message box if not. Screenshots of what it looks like with the current change are below. We can definitely move text around (for example, only include the docs link in the main text and app/architecture/framework in the collapsible details section) or do something different for the icon (for example, don't try to use the app icon and always use the standard error icon or no icon at all). @richlander @vitek-karas thoughts? The current change also tries to use the app's icon if it exists: The expanded details has the full download link:
|
I'm not sure that "Framework resolution" is a meaningful term for end users. |
Maybe "Learn about application launch failures" for both cases? |
or even "Learn more:" (or actually -- is that link to something end users will understand? perhaps the text should be "More information for developers:"). We probably don't want most end users to click on that... we want them to download the runtime. |
b6423d1
to
7992b24
Compare
Added cancellation/close and moved details to the expanded info section. Images in description are updated. @mairaw @richlander @vitek-karas thoughts/improvements on the wording or visual? I think the icon being in both the main dialog and title bar is odd, but apparently showing the icon in the title bar is the TaskDialog behaviour once you enable cancellation. |
In general I like it (I'll leave the exact wording for people who actually speak English)! |
Ran through this with @mairaw and @richlander - keeping the layout in its current state and going with |
Show runtime/framework not found error via a task dialog instead of a message box when possible - falls back to message box if not.
Screenshots of what it looks like with the current change are below. We can definitely move text around (for example, only include the docs link in the main text and app/architecture/framework in the collapsible details section) or do something different for the icon (for example, don't try to use the app icon and always use the standard error icon or no icon at all).
Resolves #71288
Related: #3816
@richlander @vitek-karas thoughts?
The current change also tries to use the app's icon if it exists:
The expanded details has the full details including the download link: