Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TaskDialog for error dialog in Windows GUI apps #78087

Merged
merged 4 commits into from
Jan 18, 2023

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Nov 9, 2022

Show runtime/framework not found error via a task dialog instead of a message box when possible - falls back to message box if not.

Screenshots of what it looks like with the current change are below. We can definitely move text around (for example, only include the docs link in the main text and app/architecture/framework in the collapsible details section) or do something different for the icon (for example, don't try to use the app icon and always use the standard error icon or no icon at all).

Resolves #71288
Related: #3816

@richlander @vitek-karas thoughts?

image
image

The current change also tries to use the app's icon if it exists:
image

The expanded details has the full details including the download link:
image
image

@vitek-karas
Copy link
Member

Adding @mairaw - this is one of the common ways to get to the website. Maybe there's opportunity to provide consistent UX and terminology.

I think we can design the default dialog content to be "End user friendly" and then include the technical details in the collapsed drop down section of the dialog.

Nit: (I noticed this with our current dialog as well) - the dialog doesn't have the standard "Red X" close button in the top right corner. I think ideally it should have that.

@ghost
Copy link

ghost commented Nov 9, 2022

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Show runtime/framework not found error via a task dialog instead of a message box when possible - falls back to message box if not.

Screenshots of what it looks like with the current change are below. We can definitely move text around (for example, only include the docs link in the main text and app/architecture/framework in the collapsible details section) or do something different for the icon (for example, don't try to use the app icon and always use the standard error icon or no icon at all).

@richlander @vitek-karas thoughts?

image
image

The current change also tries to use the app's icon if it exists:
image

The expanded details has the full download link:
image

Author: elinor-fung
Assignees: -
Labels:

area-Host

Milestone: -

@ghost ghost assigned elinor-fung Nov 9, 2022
@elinor-fung
Copy link
Member Author

Some example variations for reference:

Technical details moved to collapsed section:
image
Expanded (technical details end up after the docs link)
image

Expanded info can also be put in the footer instead of the main content:
image

With cancellation (title bar X button, esc to close) - also ends up with the icon in the title bar:
image

No icon:
image

@danmoseley
Copy link
Member

I'm not sure that "Framework resolution" is a meaningful term for end users.

@elinor-fung
Copy link
Member Author

elinor-fung commented Nov 9, 2022

Maybe "Learn about application launch failures" for both cases?

@danmoseley
Copy link
Member

danmoseley commented Nov 9, 2022

Maybe "Learn about application launch failures" for both cases?

or even "Learn more:" (or actually -- is that link to something end users will understand? perhaps the text should be "More information for developers:"). We probably don't want most end users to click on that... we want them to download the runtime.

@elinor-fung
Copy link
Member Author

The link is intended to be a page that end users will understand. But yeah, we'd expect/want users to just be able to use the download button to get the right runtime.

Everything moved to collapsible details section (whitespace looks kind of awkward - I feel like we want some basic text there):
image

@elinor-fung elinor-fung marked this pull request as ready for review November 30, 2022 05:32
@elinor-fung
Copy link
Member Author

Added cancellation/close and moved details to the expanded info section. Images in description are updated.

@mairaw @richlander @vitek-karas thoughts/improvements on the wording or visual?

I think the icon being in both the main dialog and title bar is odd, but apparently showing the icon in the title bar is the TaskDialog behaviour once you enable cancellation.

@vitek-karas
Copy link
Member

In general I like it (I'll leave the exact wording for people who actually speak English)!
I agree that the two icons are a bit weird, but I don't think it's too bad - for me the presence of the cancellation outweighs it.

@elinor-fung
Copy link
Member Author

Ran through this with @mairaw and @richlander - keeping the layout in its current state and going with Required: instead of Framework: in the details section.

@elinor-fung elinor-fung merged commit 7392fb7 into dotnet:main Jan 18, 2023
@elinor-fung elinor-fung deleted the task-dialog branch January 18, 2023 15:44
@ghost ghost locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use modern-themed buttons in the host error message box.
3 participants