Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/linker #78020

Merged
merged 16 commits into from
Dec 5, 2022

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Nov 8, 2022

This pull request updates the following dependencies

From https://github.com/dotnet/linker

  • Subscription: 0d6d6ae4-f71f-4395-53e6-08d8e409d87d
  • Build: 20221202.1
  • Date Produced: December 2, 2022 11:01:10 AM UTC
  • Commit: da244b780a1d1755cb7cb389df599fe650726892
  • Branch: refs/heads/main

…107.2

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22552.1 -> To Version 7.0.100-1.22557.2
…109.1

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22552.1 -> To Version 7.0.100-1.22559.1
…109.2

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22552.1 -> To Version 7.0.100-1.22559.2
…110.1

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22552.1 -> To Version 7.0.100-1.22560.1
@radical
Copy link
Member

radical commented Nov 14, 2022

wasm build failure with trimming:

ILLink : error IL1012: IL Trimmer has encountered an unexpected error. Please report the issue at https://github.com/dotnet/linker/issues [/__w/1/s/src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/System.Text.RegularExpressions.Tests.csproj::TargetFramework=net7.0]
##[error]ILLink(0,0): error IL1012: (NETCORE_ENGINEERING_TELEMETRY=Build) IL Trimmer has encountered an unexpected error. Please report the issue at https://github.com/dotnet/linker/issues
  Fatal error in IL Linker
  Unhandled exception. System.IndexOutOfRangeException: Index was outside the bounds of the array.
     at Mono.Linker.Steps.UnreachableBlocksOptimizer.BodyReducer.RewriteCondition(Int32 index, Instruction instr, Int32 operand)
     at Mono.Linker.Steps.UnreachableBlocksOptimizer.BodyReducer.RemoveConditions()
     at Mono.Linker.Steps.UnreachableBlocksOptimizer.BodyReducer.RewriteBody()
     at Mono.Linker.Steps.UnreachableBlocksOptimizer.ProcessMethod(MethodDefinition method)
     at Mono.Linker.Steps.MarkStep.MarkMethodBody(MethodBody body)
     at Mono.Linker.Steps.MarkStep.ProcessMethod(MethodDefinition method, DependencyInfo& reason, MessageOrigin& origin)
     at Mono.Linker.Steps.MarkStep.ProcessQueue()
     at Mono.Linker.Steps.MarkStep.ProcessPrimaryQueue()
     at Mono.Linker.Steps.MarkStep.Process()
     at Mono.Linker.Steps.MarkStep.Process(LinkContext context)
     at Mono.Linker.Pipeline.ProcessStep(LinkContext context, IStep step)
     at Mono.Linker.Pipeline.Process(LinkContext context)
     at Mono.Linker.Driver.Run(ILogger customLogger)
     at Mono.Linker.Driver.Main(String[] args)

@eerhardt @marek-safar

@marek-safar
Copy link
Contributor

That's problem caused by my change, looking into it.

…114.1

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22552.1 -> To Version 7.0.100-1.22564.1
…117.3

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22552.1 -> To Version 7.0.100-1.22567.3
…121.1

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22552.1 -> To Version 7.0.100-1.22571.1
…122.1

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22552.1 -> To Version 7.0.100-1.22572.1
@marek-safar
Copy link
Contributor

The break comes from dotnet/linker#3124

@sbomer is it intentional breaking change? Could you commit the intended fix?

@sbomer
Copy link
Member

sbomer commented Nov 23, 2022

Yes, I'm making a fix here: dotnet/linker#3131

…123.1

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22552.1 -> To Version 7.0.100-1.22573.1
dotnet-maestro bot and others added 2 commits November 25, 2022 13:22
…125.1

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22552.1 -> To Version 7.0.100-1.22575.1
@marek-safar
Copy link
Contributor

@sbomer I think the change broke the trimming tests (presumably because they are fully rooted now)

…128.3

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22552.1 -> To Version 7.0.100-1.22578.3
@sbomer
Copy link
Member

sbomer commented Nov 29, 2022

I'll take a look. It's also now blocked on #78817. We might want to roll back dotnet/linker#3135 if we want this PR to get unblocked first.

@sbomer sbomer mentioned this pull request Nov 29, 2022
…129.3

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22552.1 -> To Version 7.0.100-1.22579.3
@akoeplinger
Copy link
Member

#78817 is unblocked now, I expect it to go in in the next few hours.

…130.1

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22552.1 -> To Version 7.0.100-1.22580.1
…202.1

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22552.1 -> To Version 7.0.100-1.22602.1
@marek-safar marek-safar merged commit 5f51269 into main Dec 5, 2022
@marek-safar marek-safar deleted the darc-main-15341b8c-e1a3-4642-8792-347f0bee983e branch December 5, 2022 08:18
@ghost ghost locked as resolved and limited conversation to collaborators Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants