Add missing docs for M.E.Configuration.Xml
#77188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to: dotnet#43869
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue DetailsContributes to: #43869
|
tarekgh
approved these changes
Oct 18, 2022
gewarren
approved these changes
Oct 19, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a quick skim over dotnet/runtime repo for
Microsoft.Extensions.ConfigurationMicrosoft.Extensions.Configuration.CommandLineMicrosoft.Extensions.Configuration.IniMicrosoft.Extensions.Configuration.JsonMicrosoft.Extensions.Configuration.Memoryand noticed no change is needed here. All listed APIs already have xml docs in the source code.
The default ctors maybe are just missing in the dotnet-api-docs repo itself. No action needed on dotnet/runtime repo side.
Also note,
Microsoft.Extensions.Configuration.NewtonsoftJsonsource code does not live in dotnet/runtime.For dotnet/runtime repo seems we'd want to just docs on one API over in this PR.
Contributes to: #43869