Add cecil as a dependency of the runtime #77029
Conversation
Enables the subscription
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
There was a problem hiding this comment.
I think you might need to run darc update-dependencies --source-repo https://github.com/dotnet/cecil to get the version info in here.
Also, can you put the info in Versions.props into the super large <PropertyGroup> at the bottom next to the <StaticCsVersion> item with a comment above it stating which repo it's from (the extra line ends up significantly reducing merge conflicts)?
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsAdd cecil as a dependency of the runtime
|
|
why is cecil needed when there is a managed typesystem with dependency analysis available for production use? |
|
There’s plans to move the linker to the runtime repo: #75278 The linker uses Cecil, so a Cecil dependency is needed until the linker moves to the managed type system, if that ever happens. |
|
Why add a dependency that is not consumed anywhere? All this does is create a property that's not used and can get out of sync, and churns the repo in PRs to update that property. Can you wait to make this change until you consume that property? |
tlakollo
added
the
NO-MERGE
Yes, so far Im prototyping how this would work with consuming the cecil package in #77149. Not sure if just mark it as NO-MERGE or just close this PR |
|
It's usually best to keep the PR as a draft PR and to have the no-review and no-merge labels if we are not intending to merge this. Otherwise, people might come to the PR, see that it is approved and green, and might just merge it. |
|
Closing this since #78077 got merged |
ghost
locked as resolved and limited conversation to collaborators
Add cecil as a dependency of the runtime
Enables the subscription