Resolve missing triple-slash in Microsoft.Extensions.Primitives #76098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-extensions-primitives Issue DetailsResolves much of the missing triple-slash as documented in #43920. Namespace description still is a TODO, and a separate PR will be opened in the api docs repo for it. To my knowledge, the following are obsolete:
|
src/libraries/Microsoft.Extensions.Primitives/src/Extensions.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Primitives/src/StringSegmentComparer.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Primitives/src/StringTokenizer.cs
Outdated
Show resolved
Hide resolved
carlossanlop
approved these changes
Sep 23, 2022
There was a problem hiding this comment.
Some minor suggestions. Otherwise, LGTM.
cc @gewarren if you'd like to provide the language review now, before porting.
Co-authored-by: Carlos Sanchez <[email protected]>
gewarren
approved these changes
Sep 23, 2022
tarekgh
reviewed
Sep 23, 2022
src/libraries/Microsoft.Extensions.Primitives/src/StringSegmentComparer.cs
Show resolved
Hide resolved
tarekgh
approved these changes
Sep 23, 2022
tarekgh
reviewed
Sep 23, 2022
src/libraries/Microsoft.Extensions.Primitives/src/StringSegmentComparer.cs
Outdated
Show resolved
Hide resolved
tarekgh
reviewed
Sep 23, 2022
src/libraries/Microsoft.Extensions.Primitives/src/StringSegmentComparer.cs
Outdated
Show resolved
Hide resolved
tarekgh
reviewed
Sep 23, 2022
src/libraries/Microsoft.Extensions.Primitives/src/StringSegmentComparer.cs
Outdated
Show resolved
Hide resolved
|
Re-requesting after changes to |
carlossanlop
approved these changes
Sep 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves much of the missing triple-slash as documented in #43920. Namespace description still is a TODO, and a separate PR will be opened in the api docs repo for it.
To my knowledge, the following are obsolete: