Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Don't use MS.Build.NoTargets SDK for runtime tests #75939

Merged
merged 1 commit into from
Sep 21, 2022
Merged

[wasm] Don't use MS.Build.NoTargets SDK for runtime tests #75939

merged 1 commit into from
Sep 21, 2022

Conversation

radical
Copy link
Member

@radical radical commented Sep 21, 2022

This will also avoid intermittent failures like #75391

@radical
[wasm] Don't use MS.Build.NoTargets SDK for runtime tests
ddeb41c 
This will also avoid intermittent failures like dotnet#75391
@ghost ghost assigned radical Sep 21, 2022
@ghost
Copy link

ghost commented Sep 21, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This will also avoid intermittent failures like #75391

Author: radical
Assignees: radical
Labels:

area-Infrastructure-mono
Milestone: -

@radical radical added arch-wasm WebAssembly architecture area-Build-mono and removed area-Infrastructure-mono labels Sep 21, 2022
@radical radical marked this pull request as ready for review September 21, 2022 02:13
@lewing lewing merged commit 0d765e9 into dotnet:main Sep 21, 2022
@radical radical deleted the wasm-runtimetests branch September 21, 2022 02:51
@naricc naricc mentioned this pull request Sep 23, 2022
Closed
@radical
Copy link
Member Author

radical commented Sep 23, 2022

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3116150518

@github-actions github-actions bot mentioned this pull request Sep 23, 2022
Merged
@ViktorHofer
Copy link
Member

Were you able to root cause why the Microsoft.Build.NoTargets SDK caused problems? cc @jeffkl

@jeffkl
Copy link

jeffkl commented Sep 26, 2022

Were you able to root cause why the Microsoft.Build.NoTargets SDK caused problems? cc @jeffkl

It looks like an issue with the NuGet-based MSBuild project SDK resolver. This is tracked here: NuGet/Home#10935

And I'm actively working on major improvements to the resolver: NuGet/Home#11441

Not using NoTargets is a fine workaround in the meantime though, especially if you don't really need it.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing lewing approved these changes

@naricc naricc Awaiting requested review from naricc

@steveisok steveisok Awaiting requested review from steveisok

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@radical @ViktorHofer @jeffkl @lewing