-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm][debugger] Removed internalProperties group. #75904
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsFixes #75778. Motivation: #75778 (comment). It fixes a bug from net 7, so will need backporting.
|
/backport to release/7.0-rc2 |
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3091753776 |
If the tests are passing, LGTM. |
/backport to release/7.0-rc2 |
Started backporting to release/7.0-rc2: https://github.com/dotnet/runtime/actions/runs/3091794256 |
@ilonatommy just curious, is VS using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look fine to me. I just have a few questions:
- How is VS surfacing the public/private/protected members? Is it reading anything other than
"result"
? - We should also test this same thing with
protected
members being overridden by a derived class. And the base/derived split should be tested for being in the user code, and beingbase (!user code) -> derived(user code)
Also, it would be a good idea to remove all the |
It is using it in the meaning: they are displayed. However, the difference between them and |
I agree and Thays already mentioned this idea as well. The PR with it will be out soon. |
Fixes #75778.
Motivation: #75778 (comment).
It fixes a bug from net 7, so will need backporting.