[release/7.0-rc2] KeyChar should be preserved for Ctrl+Letter #75861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-system-console Issue DetailsBackport of #75853 to release/7.0-rc2 /cc @adamsitnik Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
jozkee
approved these changes
Sep 19, 2022
|
Can we please get Powershell to test private binaries before merging this? |
@daxian-dbw Would that be possible? |
rbhanda
added
Servicing-approved
|
Tactics says -- please do merge into RC2, don't wait for Powershell to verify it, but we would like them to verify it as soon as they can (with privates if necessary) and test around for any other issues. |
|
CI green, Tactics approved, signed off. Fully baked and ready to merge. |
carlossanlop
added a commit
that referenced
this pull request
Sep 26, 2022
* Fix querying L3 cache size on osx-x64 (#75870) Co-authored-by: Filip Navara <[email protected]> * KeyChar should be preserved for Ctrl+Letter (#75861) Co-authored-by: Adam Sitnik <[email protected]> * Try re-enabling System.Transactions.Local tests on Arm64 (#75703) Co-authored-by: Jan Kotas <[email protected]> * Updating inbox source generators to Roslyn 4.4 and removing polyfill approach (#75717) (#75875) * Removed internalProperties group from proxy and tests. (#75906) Co-authored-by: Ilona Tomkowicz <[email protected]> * [release/7.0-rc2] Fixing SpanHelpers.LastIndexOfAnyValueType to no longer create out of bounds GC refs (#75885) * Fixing SpanHelpers.LastIndexOfAnyValueType to no longer create out of bounds GC refs * Apply suggestions from code review Co-authored-by: Adam Sitnik <[email protected]> * Adjusting the comment as per PR review feedback Co-authored-by: Tanner Gooding <[email protected]> Co-authored-by: Adam Sitnik <[email protected]> * Bump intellisense package for RC2 to include latest comments for Numerics (#75938) Co-authored-by: carlossanlop <[email protected]> * [release/7.0-rc2] [Mono] Restore old code to solve the recent SpanHelpers regressions (#75996) * bring back the old code... * bring back more old code * Use an ifdef around clr code instead of a separate file * Delete SpanHelpers.Clr.cs * Remove a remaining INumber<T> helper from mono Co-authored-by: Adam Sitnik <[email protected]> Co-authored-by: Jeff Handley <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Filip Navara <[email protected]> Co-authored-by: Adam Sitnik <[email protected]> Co-authored-by: Jan Kotas <[email protected]> Co-authored-by: Jose Perez Rodriguez <[email protected]> Co-authored-by: Ilona Tomkowicz <[email protected]> Co-authored-by: Tanner Gooding <[email protected]> Co-authored-by: Carlos Sanchez <[email protected]> Co-authored-by: carlossanlop <[email protected]> Co-authored-by: Jeff Handley <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #75853 to release/7.0-rc2
/cc @adamsitnik
Customer Impact
PowerShell can't update to RC1 (see #75795 for all details).
Testing
New unit tests were added, and they are passing.
Risk
Relatively low, as it's a very simple change and we have great test coverage.