[release/7.0] Update dependencies from dotnet/roslyn-analyzers #75675
Conversation
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…uild 20220914.1 Microsoft.CodeAnalysis.NetAnalyzers From Version 7.0.0-preview1.22452.2 -> To Version 7.0.0-preview1.22464.1
|
Almost all CI failed in this PR. @tannergooding I see some problems coming from Numerics. Can you please take a look? |
|
Look to be issues with the new analyzer. CC. @buyaa-n |
|
Hm strange, I have tested with runtime did not fail anything, looking |
|
The bug introduced with a code review updates which was not tested with runtime, the fix is up for review (tested with the repro), after this merged we could update the dogfood with next available build |
|
@buyaa-n I think your fix should get cherry-picked into this PR, so we merge both together and we don't break the branch. |
|
I don't think that would work, it is updating analyzers release version, not updating the code. As this PR is triggered automatically I hope after the next analyzer build it would trigger another PR (else we might bump manually). So think this PR better to be closed, but don't know how this process is handled in infra CC @ViktorHofer |
|
Can the analyzer be temporarily disabled to unblock this PR and then re-enabled in the PR that includes the fix? |
|
Yes, I can update that in this PR if that is what we want |
|
Update: Actually I don't think it is updating the SDK version, it should only apply to runtime. So I will push a commit disabling the analyzer |
buyaa-n
force-pushed
the
darc-release/7.0-bc4afbfd-2fa1-4ccd-8614-153e044a768f
branch
from
4fc12f0 to
9997839
Compare
…uild 20220916.1 Microsoft.CodeAnalysis.NetAnalyzers From Version 7.0.0-preview1.22452.2 -> To Version 7.0.0-preview1.22466.1
|
@buyaa-n the Maestro Bot just updated this PR with a newer version of the analyzer package which presumably includes your fix. You now want to revert the two editorconfig changes in this PR. |
This reverts commit 9997839.
https://github.com/dotnet/runtime into darc-release/7.0-bc4afbfd-2fa1-4ccd-8614-153e044a768f
Done, now new failures are unrelated |
There was a problem hiding this comment.
Approving now that the original failures have been fixed. 
Infra change only.
The existing failures are all unrelated:
Installer Build and Test coreclr Linux_musl_x64 Release
HostActivation failure: #75429 (marked as dupe of #74328)
Libraries Test Run release coreclr Linux x64 Debug
System.Net.Http.Functional.Tests failure is #75611
mono llvmaot Pri0 Runtime Tests Run Linux x64 release | mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
PInvokeDetach failure: #73040
Build Browser wasm Linux Release AllSubsets_Mono_RuntimeTests
JIT Hardware intrinsics failure: #75391
JIT PGO failure: #75867
carlossanlop
deleted the
darc-release/7.0-bc4afbfd-2fa1-4ccd-8614-153e044a768f
branch
ghost
locked as resolved and limited conversation to collaborators
This pull request updates the following dependencies
From https://github.com/dotnet/roslyn-analyzers