Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Don't try to build PGO tools on platforms with no CoreCLR port. #75003

Merged
merged 3 commits into from
Sep 6, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 2, 2022

Backport of #74147 to release/7.0

/cc @directhex

Customer Impact

This should only impact customer-supported platforms like s390x and ppc64le, and the backport is by request of the community.

Testing

Customer indicates that the PR in question works for them. CI is fine otherwise on our side.

Risk

Should not impact any of our scenarios.

@ghost
Copy link

ghost commented Sep 2, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #74147 to release/7.0

/cc @directhex

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@ghost
Copy link

ghost commented Sep 2, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #74147 to release/7.0

/cc @directhex

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

@directhex directhex added the arch-s390x Related to s390x architecture (unsupported) label Sep 2, 2022
@carlossanlop
Copy link
Member

Re-running the failed CI legs. They were a known, unrelated issue that has already been mitigated. (the max limit of runs was exceeded).

@carlossanlop
Copy link
Member

carlossanlop commented Sep 2, 2022

@mdh1418 or @akoeplinger can we get a code review sign off?
@steveisok or @lewing do you approve this backport?

Edit: @marek-safar please approve this backport.

@akoeplinger akoeplinger merged commit 3cb7fe7 into release/7.0 Sep 6, 2022
@akoeplinger akoeplinger deleted the backport/pr-74147-to-release/7.0 branch September 6, 2022 09:19
@ghost ghost locked as resolved and limited conversation to collaborators Oct 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-s390x Related to s390x architecture (unsupported) area-Infrastructure-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants