Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appstart benchmark improvements #74799

Merged
merged 3 commits into from
Aug 31, 2022
Merged

appstart benchmark improvements #74799

merged 3 commits into from
Aug 31, 2022

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Aug 30, 2022 •
edited
Loading

  • preload into html file of samples
  • mime type for json
  • silence the console in AppStart iframe benchmark

@pavelsavara pavelsavara added this to the 8.0.0 milestone Aug 30, 2022
@pavelsavara pavelsavara self-assigned this Aug 30, 2022
@ghost
Copy link

ghost commented Aug 30, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 8.0.0

@pavelsavara pavelsavara marked this pull request as ready for review August 30, 2022 11:15
@pavelsavara pavelsavara requested a review from maraf August 31, 2022 09:12
@pavelsavara pavelsavara merged commit b82f254 into dotnet:main Aug 31, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 30, 2022
@pavelsavara pavelsavara deleted the wasm_benchmark_improvements branch October 13, 2022 10:03
@lewing
Copy link
Member

lewing commented Jan 25, 2023

https://radekdoulik.github.io/WasmPerformanceMeasurements/?startDate=2022-08-31T10%3A21%3A55.000Z&endDate=2022-08-31T19%3A50%3A47.000Z&tasks=%2CAppStart&flavors=2

@pavelsavara
Copy link
Member Author

Does it mean that preload is not helping ? How come ?

@radekdoulik
Copy link
Member

IIRC we were changing these later and now we have

<head>
  <title>Wasm Browser Advanced Sample</title>
  <meta charset="UTF-8">
  <meta name="viewport" content="width=device-width, initial-scale=1.0">
  <script type='module' src="./main.js"></script>
  <script type='module' src="./dotnet.js"></script>
  <link rel="preload" href="./mono-config.json" as="fetch" crossorigin="anonymous">
  <link rel="prefetch" href="./dotnet.wasm" as="fetch" crossorigin="anonymous">
  <link rel="prefetch" href="./icudt.dat" as="fetch" crossorigin="anonymous">
  <link rel="prefetch" href="./managed/System.Private.CoreLib.dll" as="fetch" crossorigin="anonymous">
</head>

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maraf maraf maraf approved these changes

@radekdoulik radekdoulik Awaiting requested review from radekdoulik

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pavelsavara @lewing @radekdoulik @maraf