Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LoongArch64] amend the tests' building on LA64. #73840

Merged
merged 2 commits into from
Aug 17, 2022
Merged

[LoongArch64] amend the tests' building on LA64. #73840

merged 2 commits into from
Aug 17, 2022

Conversation

shushanhf
Copy link
Contributor

This PR is part of the issue #69705 to amend the LA's port.

This PR is fixing the tests building configuration on LoongArch64.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 12, 2022
@shushanhf
Copy link
Contributor Author

shushanhf commented Aug 12, 2022 •
edited
Loading

Hi, @JulieLeeMSFT
Could you help adding the label and proper reviewer ?
Thanks

@JulieLeeMSFT JulieLeeMSFT added this to the 8.0.0 milestone Aug 12, 2022
kunalspathak
kunalspathak approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We will merge it after we fork for .NET 8.

@teo-tsirpanis teo-tsirpanis added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 12, 2022
@shushanhf
Move the -DTARGET_ARMARCH and -DTARGET_ARMARCH
7f945c7 
to the `Common/Platform/platformdefines.h`.
@am11 am11 added area-Infrastructure and removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) labels Aug 15, 2022
@ghost
Copy link

ghost commented Aug 15, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR is part of the issue #69705 to amend the LA's port.

This PR is fixing the tests building configuration on LoongArch64.

Author: shushanhf
Assignees: kunalspathak, shushanhf
Labels:

area-Infrastructure, community-contribution
Milestone: 8.0.0

am11
am11 approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@am11 am11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@akoeplinger akoeplinger merged commit 25e5085 into dotnet:main Aug 17, 2022
@shushanhf shushanhf deleted the LA_tests_configure branch August 18, 2022 00:51
@ghost ghost locked as resolved and limited conversation to collaborators Sep 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kunalspathak kunalspathak kunalspathak approved these changes

@am11 am11 am11 approved these changes

Assignees

@kunalspathak kunalspathak

@shushanhf shushanhf

Labels
arch-loongarch64 area-Infrastructure community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@shushanhf @am11 @kunalspathak @akoeplinger @teo-tsirpanis @JulieLeeMSFT