-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support managed debugging when CET is enabled #73572
Conversation
Tagging subscribers to this area: @tommcdon Issue DetailsThis change adds out of process SetThreadContext support on Windows x64. The feature will be automatically enabled if the process is enabled for CET or with a configuration setting (useful for testing purposes). I've validated our mainline scenarios with the Visual Studio debugger, including breakpoints, stepping, mixed-mode debugging, and Edit-And-Continue (Hot Reload).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo comments inline
Remove RS GetLiveContext/SetLiveContext implementations Update debugger contract
…t with HandleSetThreadContextNeeded implementation
Test failures look unrelated to this PR and so merging |
This change adds out of process SetThreadContext support on Windows x64. The feature will be automatically enabled if the process is enabled for CET or with a configuration setting (useful for testing purposes). I've validated our mainline scenarios with the Visual Studio debugger, including breakpoints, stepping, mixed-mode debugging, and Edit-And-Continue (Hot Reload).