Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support managed debugging when CET is enabled #73572

Merged
merged 5 commits into from
Aug 10, 2022

Conversation

tommcdon
Copy link
Member

@tommcdon tommcdon commented Aug 8, 2022

This change adds out of process SetThreadContext support on Windows x64. The feature will be automatically enabled if the process is enabled for CET or with a configuration setting (useful for testing purposes). I've validated our mainline scenarios with the Visual Studio debugger, including breakpoints, stepping, mixed-mode debugging, and Edit-And-Continue (Hot Reload).

@ghost
Copy link

ghost commented Aug 8, 2022

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

This change adds out of process SetThreadContext support on Windows x64. The feature will be automatically enabled if the process is enabled for CET or with a configuration setting (useful for testing purposes). I've validated our mainline scenarios with the Visual Studio debugger, including breakpoints, stepping, mixed-mode debugging, and Edit-And-Continue (Hot Reload).

Author: tommcdon
Assignees: -
Labels:

area-Diagnostics-coreclr

Milestone: -

Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comments inline

Remove RS GetLiveContext/SetLiveContext implementations
Update debugger contract
@runfoapp runfoapp bot mentioned this pull request Aug 9, 2022
@tommcdon
Copy link
Member Author

Test failures look unrelated to this PR and so merging

@tommcdon tommcdon merged commit a3fb0d3 into dotnet:main Aug 10, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants