Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LoongArch64] delete the emitIns_R_R_Imm(). #73509

Merged
merged 1 commit into from
Aug 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/coreclr/jit/codegenloongarch64.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9313,7 +9313,17 @@ void CodeGen::genFnPrologCalleeRegArgs()
// So, after we save `A7` on the stack in prolog, it has to copy the stack slot of the split struct
// which was passed by the caller. Here we load the stack slot to `REG_SCRATCH`, and save it
// on the stack following the `A7` in prolog.
GetEmitter()->emitIns_R_R_Imm(INS_ld_d, size, REG_SCRATCH, REG_SPBASE, genTotalFrameSize());
if (emitter::isValidSimm12(genTotalFrameSize()))
{
GetEmitter()->emitIns_R_R_I(INS_ld_d, size, REG_SCRATCH, REG_SPBASE, genTotalFrameSize());
shushanhf marked this conversation as resolved.
Show resolved Hide resolved
}
else
{
assert(!EA_IS_RELOC(size));
GetEmitter()->emitIns_I_la(size, REG_SCRATCH, genTotalFrameSize());
GetEmitter()->emitIns_R_R_R(INS_ldx_d, size, REG_SCRATCH, REG_SPBASE, REG_SCRATCH);
}

if (emitter::isValidSimm12(baseOffset))
{
GetEmitter()->emitIns_S_R(INS_st_d, size, REG_SCRATCH, varNum, TARGET_POINTER_SIZE);
Expand Down
50 changes: 0 additions & 50 deletions src/coreclr/jit/emitloongarch64.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1460,56 +1460,6 @@ void emitter::emitIns_R_R_I(
appendToCurIG(id);
}

/*****************************************************************************
*
* Add an instruction referencing two registers and a constant.
* Also checks for a large immediate that needs a second instruction
* and will load it in reg1
*
*/
void emitter::emitIns_R_R_Imm(instruction ins, emitAttr attr, regNumber reg1, regNumber reg2, ssize_t imm)
{
assert(isGeneralRegister(reg1));
assert(reg1 != reg2);

bool immFits = true;

#ifdef DEBUG
switch (ins)
{
case INS_addi_w:
case INS_addi_d:
case INS_ld_d:
immFits = isValidSimm12(imm);
break;

case INS_andi:
case INS_ori:
case INS_xori:
immFits = (0 <= imm) && (imm <= 0xfff);
break;

default:
assert(!"Unsupported instruction in emitIns_R_R_Imm");
}
#endif

if (immFits)
{
emitIns_R_R_I(ins, attr, reg1, reg2, imm);
}
else
{
// Load 'imm' into the reg1 register
// then issue: 'ins' reg1, reg2, reg1
//
assert(!EA_IS_RELOC(attr));
emitIns_I_la(attr, reg1, imm);
assert(ins == INS_ld_d);
emitIns_R_R_R(INS_ldx_d, attr, reg1, reg2, reg1);
}
}

/*****************************************************************************
*
* Add an instruction referencing three registers.
Expand Down
3 changes: 0 additions & 3 deletions src/coreclr/jit/emitloongarch64.h
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,6 @@ void emitIns_R_R(instruction ins, emitAttr attr, regNumber reg1, regNumber reg2,
void emitIns_R_R_I(
instruction ins, emitAttr attr, regNumber reg1, regNumber reg2, ssize_t imm, insOpts opt = INS_OPTS_NONE);

// Checks for a large immediate that needs a second instruction
void emitIns_R_R_Imm(instruction ins, emitAttr attr, regNumber reg1, regNumber reg2, ssize_t imm);

void emitIns_R_R_R(
instruction ins, emitAttr attr, regNumber reg1, regNumber reg2, regNumber reg3, insOpts opt = INS_OPTS_NONE);

Expand Down