port SpanHelpers.IndexOfAny(ref byte, byte, byte, int) to Vector128/256 #73384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-memory Issue Detailsx64On par. BenchmarkDotNet=v0.13.1.1828-nightly, OS=Windows 10 (10.0.18363.2212/1909/November2019Update/19H2)
Intel Xeon CPU E5-1650 v4 3.60GHz, 1 CPU, 12 logical and 6 physical cores
.NET SDK=7.0.100-rc.1.22403.8
[Host] : .NET 7.0.0 (7.0.22.40210), X64 RyuJIT AVX2
LaunchCount=9
arm64BDN is reporting less than a nanosecond difference, which maps to 4%. On arm64 I don't have the tool that would allow me to verify whether it's caused by an alginment or codegen change. BenchmarkDotNet=v0.13.1.1828-nightly, OS=ubuntu 20.04
Unknown processor
.NET SDK=7.0.100-rc.1.22403.8
[Host] : .NET 7.0.0 (7.0.22.40210), Arm64 RyuJIT AdvSIMD
LaunchCount=9
|
tannergooding
approved these changes
Aug 4, 2022
stephentoub
approved these changes
Aug 5, 2022
75 tasks
|
WASM AOT compilation failed in this PR and is now failing on |
|
Submitting revert in #73476 |
|
@adamsitnik Please make sure to add links to the known issues tracking the failures when merging with red CI next time. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x64
On par.
arm64
BDN is reporting less than a nanosecond difference, which maps to 4%. On arm64 I don't have the tool that would allow me to verify whether it's caused by an alginment or codegen change.
contributes to #64451