Add innerException to ResourceReader FileNotFoundException #72957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-resources Issue DetailsFixes #48159 cc: @ericstj @filipnavara
|
danmoseley
approved these changes
Jul 27, 2022
danmoseley
reviewed
Jul 27, 2022
src/libraries/System.Private.CoreLib/src/System/Resources/ResourceReader.cs
Show resolved
Hide resolved
…urceReader.cs Co-authored-by: Dan Moseley <[email protected]>
ericstj
reviewed
Jul 27, 2022
src/libraries/System.Private.CoreLib/src/System/Resources/ResourceReader.cs
Show resolved
Hide resolved
This is a misnomer. We actually do support deserialization in this case, but the code from when we didn't was left behind. Have a look at my suggestion. |
stephentoub
approved these changes
Aug 1, 2022
joperezr
changed the title
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48159
cc: @ericstj @filipnavara