Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][Mono] Enable tests disabled by issue 36882. #72931

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

lateralusX
Copy link
Member

@lateralusX lateralusX commented Jul 27, 2022

WIP.

Re-enabled tests pass locally on iOSSimulator using Full AOT LLVM, this PR revalidates pass rate on physical devices on CI for tests disabled by issue #36882.

Fixes #36882

@ghost
Copy link

ghost commented Jul 27, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

WIP.

Re-enabled tests pass locally on iOSSimulator using Full AOT LLVM, this PR revalidates pass rate on physical devices on CI for tests disabled by issue #36882.

Author: lateralusX
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@lateralusX
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lateralusX
Copy link
Member Author

Looks like failures on MacCatalyst and tvOS are not related to re-enabled tests, https://dev.azure.com/dnceng/public/_build/results?buildId=1906721&view=ms.vss-test-web.build-test-results-tab.

Copy link
Member

@mdh1418 mdh1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@lateralusX lateralusX marked this pull request as ready for review July 28, 2022 15:01
@lateralusX lateralusX merged commit 50d69de into dotnet:main Jul 28, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Diagnostics.Debug.Tests fail on iOS
2 participants