Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memory fences to ByRefAssignRef on Unix ARM64 #72919

Merged
merged 3 commits into from
Jul 28, 2022

Conversation

MichalStrehovsky
Copy link
Member

@MichalStrehovsky MichalStrehovsky commented Jul 27, 2022

Fixes dotnet/runtimelab#639.

Would be nice if this did something for #72831. I'll revalidate once we have an official installer build with this since I'm not set up to do ARM64 Linux dev work locally.

@MichalStrehovsky
Copy link
Member Author

Cc @VSadov

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MichalStrehovsky MichalStrehovsky merged commit 34ea135 into main Jul 28, 2022
@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky-patch-2 branch July 28, 2022 00:20
@ghost ghost locked as resolved and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NativeAOT] RhpByRefAssignRef is missing a barrier for Linux ARM32 and ARM64
3 participants