Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scan calli dependencies #72413

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Scan calli dependencies #72413

merged 1 commit into from
Jul 19, 2022

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Jul 18, 2022

Contributes to #72316

@jkotas jkotas requested a review from MichalStrehovsky as a code owner July 18, 2022 22:28
@ghost ghost assigned jkotas Jul 18, 2022
jkotas
jkotas commented Jul 18, 2022
View reviewed changes
src/coreclr/tools/aot/ILCompiler.Compiler/IL/ILImporter.Scanner.cs
@@ -767,6 +761,31 @@ private void ImportLdFtn(int token, ILOpcode opCode)
ImportCall(opCode, token);
}

private void ImportJmp(int token)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just to have all call-like opcodes together.

@jkotas
Copy link
Member Author

jkotas commented Jul 18, 2022

I considered adding a case for this to PInvoke smoke tests, but it would not actually catch the problem since the MarshalDirectiveException is rooted in other ways there.

MichalStrehovsky
MichalStrehovsky approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@MichalStrehovsky
Copy link
Member

I considered adding a case for this to PInvoke smoke tests, but it would not actually catch the problem since the MarshalDirectiveException is rooted in other ways there.

We could probably test this by having a calli that needs to do marshalling (maybe something along the lines of a calli that returns SomeSequentialLayoutClass - this would result in an allocation of the class in the stub and that for sure crashes the compiler if the class wasn't seen allocated elsewhere.

But also it's probably not worth the effort.

@runfoapp runfoapp bot mentioned this pull request Jul 19, 2022
Closed
@jkotas jkotas merged commit 07b9113 into dotnet:main Jul 19, 2022
@jkotas jkotas deleted the scan-calli branch July 19, 2022 03:44
@runfoapp runfoapp bot mentioned this pull request Jul 19, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichalStrehovsky MichalStrehovsky MichalStrehovsky approved these changes

Assignees

@jkotas jkotas

Labels
area-NativeAOT-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkotas @MichalStrehovsky