enable OpenSSL tests on arm64 mac #72294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones Issue Detailsfixes #49083
|
bartonjs
reviewed
Jul 15, 2022
| @@ -1,9 +1,6 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <PropertyGroup> | |||
| <TargetFrameworks>$(NetCoreAppCurrent)-Unix;$(NetCoreAppCurrent)-Browser</TargetFrameworks> | |||
| <!-- ActiveIssue Apple Silicon No usable version of libssl was found | |||
| https://github.com/dotnet/runtime/issues/49083 --> | |||
There was a problem hiding this comment.
Based on the comment I'm guessing that the CI images either a) don't have OSSL or b) have x86_64 OSSL which can't be loaded by an arm64 CLR.
But if the tests pass in CI, I'm cool with removing the block.
There was a problem hiding this comment.
If it does not, I'll work it out with infra team. now I know for sure Brew can do what we need.
|
Since the tests passed when force, this should be ready. |
bartonjs
approved these changes
Aug 3, 2022
MattGal
approved these changes
Aug 3, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #49083