Tar: restore directory permissions while extracting. #72078

tmds · 2022-07-13T06:52:21Z

@eerhardt @carlossanlop @dotnet/area-system-io ptal.

ghost · 2022-07-13T06:52:40Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

@eerhardt @carlossanlop @dotnet/area-system-io ptal.

Author:	tmds
Assignees:	-
Labels:	`area-System.IO`
Milestone:	-

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHelpers.Unix.cs

carlossanlop · 2022-07-13T07:04:47Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-07-13T07:04:59Z

Azure Pipelines successfully started running 1 pipeline(s).

tmds · 2022-07-13T07:09:42Z

@carlossanlop this includes the tests mentioned in #71647 (comment).

I've created the issue for Tar and Zip, this PR only handles Tar.

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHelpers.Unix.cs

src/libraries/System.Formats.Tar/tests/TarEntry/TarEntry.ExtractToFile.Tests.cs

src/libraries/System.Formats.Tar/tests/TarFile/TarFile.ExtractToDirectoryAsync.File.Tests.cs

…ault.

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarWriter.Windows.cs

Co-authored-by: Eric Erhardt <[email protected]>

src/libraries/System.Formats.Tar/tests/TarWriter/TarWriter.File.Base.Windows.cs

eerhardt

I think this looks fine. It would be good to get sign-off from @carlossanlop.

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarWriter.Windows.cs

carlossanlop · 2022-08-08T18:56:06Z

I applied the build failure fix, but then I ran the Windows tests and noticed they are failing with these errors:

    Discovering: System.Formats.Tar.Tests (method display = ClassAndMethod, method display options = None)
    Discovered:  System.Formats.Tar.Tests (found 476 test cases)
    Starting:    System.Formats.Tar.Tests (parallel test collections = on, max threads = 12)
      System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(format: V7, createTarget: False) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(204,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(TarEntryFo
  rmat format, Boolean createTarget)
             at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
          D:\runtime\src\libraries\System.Private.CoreLib\src\System\Reflection\MethodInvoker.cs(64,0): at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
      System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_Async(format: V7, createTarget: False) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(220,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
  Async(TarEntryFormat format, Boolean createTarget)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(223,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
  Async(TarEntryFormat format, Boolean createTarget)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(224,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
  Async(TarEntryFormat format, Boolean createTarget)
          --- End of stack trace from previous location ---
      System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_Async(format: V7, createTarget: True) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(220,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
  Async(TarEntryFormat format, Boolean createTarget)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(223,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
  Async(TarEntryFormat format, Boolean createTarget)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(224,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
  Async(TarEntryFormat format, Boolean createTarget)
          --- End of stack trace from previous location ---
      System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(format: V7, createTarget: True) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(204,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(TarEntryFo
  rmat format, Boolean createTarget)
             at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(Object, Object, IntPtr*)
             at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
      System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(format: Ustar, createTarget: False) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(204,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(TarEntryFo
  rmat format, Boolean createTarget)
             at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(Object, Object, IntPtr*)
             at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
      System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_Async(format: Ustar, createTarget: False) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(220,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
  Async(TarEntryFormat format, Boolean createTarget)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(223,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
  Async(TarEntryFormat format, Boolean createTarget)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(224,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
  Async(TarEntryFormat format, Boolean createTarget)
          --- End of stack trace from previous location ---
      System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(format: Ustar, createTarget: True) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(204,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(TarEntryFo
  rmat format, Boolean createTarget)
             at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(Object, Object, IntPtr*)
             at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
      System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_Async(format: Ustar, createTarget: True) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(220,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
  Async(TarEntryFormat format, Boolean createTarget)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(223,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
  Async(TarEntryFormat format, Boolean createTarget)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(224,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
  Async(TarEntryFormat format, Boolean createTarget)
          --- End of stack trace from previous location ---
      System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(format: Pax, createTarget: False) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(204,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(TarEntryFo
  rmat format, Boolean createTarget)
             at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(Object, Object, IntPtr*)
             at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
      System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_Async(format: Pax, createTarget: False) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(220,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
  Async(TarEntryFormat format, Boolean createTarget)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(223,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
  Async(TarEntryFormat format, Boolean createTarget)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(224,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
  Async(TarEntryFormat format, Boolean createTarget)
          --- End of stack trace from previous location ---
      System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(format: Pax, createTarget: True) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(204,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(TarEntryFo
  rmat format, Boolean createTarget)
             at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(Object, Object, IntPtr*)
             at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
      System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_Async(format: Pax, createTarget: True) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(220,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
  Async(TarEntryFormat format, Boolean createTarget)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(223,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
  Async(TarEntryFormat format, Boolean createTarget)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(224,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
  Async(TarEntryFormat format, Boolean createTarget)
          --- End of stack trace from previous location ---
      System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(format: Gnu, createTarget: False) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(204,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(TarEntryFo
  rmat format, Boolean createTarget)
             at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(Object, Object, IntPtr*)
             at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
      System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_Async(format: Gnu, createTarget: False) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(220,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
  Async(TarEntryFormat format, Boolean createTarget)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(223,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
  Async(TarEntryFormat format, Boolean createTarget)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(224,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
  Async(TarEntryFormat format, Boolean createTarget)
          --- End of stack trace from previous location ---
      System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(format: Gnu, createTarget: True) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(204,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(TarEntryFo
  rmat format, Boolean createTarget)
             at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(Object, Object, IntPtr*)
             at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
      System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_Async(format: Gnu, createTarget: True) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(220,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
  Async(TarEntryFormat format, Boolean createTarget)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(223,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
  Async(TarEntryFormat format, Boolean createTarget)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(224,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
  Async(TarEntryFormat format, Boolean createTarget)
          --- End of stack trace from previous location ---
      System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: V7, withContents: False) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(155,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarEntryForma
  t format, Boolean withContents)
             at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
          D:\runtime\src\libraries\System.Private.CoreLib\src\System\Reflection\MethodInvoker.cs(64,0): at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
      System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: V7, withContents: True) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(155,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarEntryForma
  t format, Boolean withContents)
             at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_Directory(Object, Object, IntPtr*)
             at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
      System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Ustar, withContents: False) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(155,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarEntryForma
  t format, Boolean withContents)
             at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_Directory(Object, Object, IntPtr*)
             at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
      System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Ustar, withContents: True) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(155,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarEntryForma
  t format, Boolean withContents)
             at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_Directory(Object, Object, IntPtr*)
             at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
      System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Pax, withContents: False) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(155,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarEntryForma
  t format, Boolean withContents)
             at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_Directory(Object, Object, IntPtr*)
             at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
      System.Formats.Tar.Tests.TarFile_CreateFromDirectoryAsync_File_Tests.VerifyIncludeBaseDirectory_Async(includeBaseDirectory: False) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarTestsBase.cs(405,0): at System.Formats.Tar.Tests.TarTestsBase.AssertEntryModeFromFileSystemEquals(TarEntry entry, UnixFileMode fileMode)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarFile\TarFile.CreateFromDirectoryAsync.File.Tests.cs(130,0): at System.Formats.Tar.Tests.TarFile_CreateFromDirectoryAsync_File_Tests.Verif
  yIncludeBaseDirectory_Async(Boolean includeBaseDirectory)
          --- End of stack trace from previous location ---
      System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Pax, withContents: True) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(155,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarEntryForma
  t format, Boolean withContents)
             at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_Directory(Object, Object, IntPtr*)
             at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
      System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Gnu, withContents: False) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(155,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarEntryForma
  t format, Boolean withContents)
             at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_Directory(Object, Object, IntPtr*)
             at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
      System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.VerifyIncludeBaseDirectory(includeBaseDirectory: False) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarTestsBase.cs(405,0): at System.Formats.Tar.Tests.TarTestsBase.AssertEntryModeFromFileSystemEquals(TarEntry entry, UnixFileMode fileMode)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarFile\TarFile.CreateFromDirectory.File.Tests.cs(108,0): at System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.VerifyIncludeBa
  seDirectory(Boolean includeBaseDirectory)
             at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
          D:\runtime\src\libraries\System.Private.CoreLib\src\System\Reflection\MethodInvoker.cs(64,0): at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
      System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Gnu, withContents: True) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(155,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarEntryForma
  t format, Boolean withContents)
             at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_Directory(Object, Object, IntPtr*)
             at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
      System.Formats.Tar.Tests.TarFile_CreateFromDirectoryAsync_File_Tests.VerifyIncludeBaseDirectory_Async(includeBaseDirectory: True) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarTestsBase.cs(405,0): at System.Formats.Tar.Tests.TarTestsBase.AssertEntryModeFromFileSystemEquals(TarEntry entry, UnixFileMode fileMode)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarFile\TarFile.CreateFromDirectoryAsync.File.Tests.cs(123,0): at System.Formats.Tar.Tests.TarFile_CreateFromDirectoryAsync_File_Tests.Verif
  yIncludeBaseDirectory_Async(Boolean includeBaseDirectory)
          --- End of stack trace from previous location ---
      System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(format: V7) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(117,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(Ta
  rEntryFormat format)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(120,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(Ta
  rEntryFormat format)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(121,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(Ta
  rEntryFormat format)
          --- End of stack trace from previous location ---
      System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.VerifyIncludeBaseDirectory(includeBaseDirectory: True) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarTestsBase.cs(405,0): at System.Formats.Tar.Tests.TarTestsBase.AssertEntryModeFromFileSystemEquals(TarEntry entry, UnixFileMode fileMode)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarFile\TarFile.CreateFromDirectory.File.Tests.cs(101,0): at System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.VerifyIncludeBa
  seDirectory(Boolean includeBaseDirectory)
             at InvokeStub_TarFile_CreateFromDirectory_File_Tests.VerifyIncludeBaseDirectory(Object, Object, IntPtr*)
             at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
      System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(format: Ustar) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(117,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(Ta
  rEntryFormat format)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(120,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(Ta
  rEntryFormat format)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(121,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(Ta
  rEntryFormat format)
          --- End of stack trace from previous location ---
      System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(format: V7) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(109,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(TarEntryFormat for
  mat)
             at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
          D:\runtime\src\libraries\System.Private.CoreLib\src\System\Reflection\MethodInvoker.cs(64,0): at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
      System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(format: Pax) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(117,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(Ta
  rEntryFormat format)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(120,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(Ta
  rEntryFormat format)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(121,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(Ta
  rEntryFormat format)
          --- End of stack trace from previous location ---
      System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(format: Ustar) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(109,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(TarEntryFormat for
  mat)
             at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_File(Object, Object, IntPtr*)
             at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
      System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(format: Pax) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(109,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(TarEntryFormat for
  mat)
             at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_File(Object, Object, IntPtr*)
             at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
      System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(format: Gnu) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(117,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(Ta
  rEntryFormat format)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(120,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(Ta
  rEntryFormat format)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(121,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(Ta
  rEntryFormat format)
          --- End of stack trace from previous location ---
      System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(format: Gnu) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(109,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(TarEntryFormat for
  mat)
             at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_File(Object, Object, IntPtr*)
             at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
      System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Async(format: V7, withContents: False) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(167,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
  nc(TarEntryFormat format, Boolean withContents)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(170,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
  nc(TarEntryFormat format, Boolean withContents)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(171,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
  nc(TarEntryFormat format, Boolean withContents)
          --- End of stack trace from previous location ---
      System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Async(format: V7, withContents: True) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(167,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
  nc(TarEntryFormat format, Boolean withContents)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(170,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
  nc(TarEntryFormat format, Boolean withContents)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(171,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
  nc(TarEntryFormat format, Boolean withContents)
          --- End of stack trace from previous location ---
      System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Async(format: Ustar, withContents: False) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(167,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
  nc(TarEntryFormat format, Boolean withContents)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(170,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
  nc(TarEntryFormat format, Boolean withContents)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(171,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
  nc(TarEntryFormat format, Boolean withContents)
          --- End of stack trace from previous location ---
      System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Async(format: Ustar, withContents: True) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(167,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
  nc(TarEntryFormat format, Boolean withContents)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(170,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
  nc(TarEntryFormat format, Boolean withContents)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(171,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
  nc(TarEntryFormat format, Boolean withContents)
          --- End of stack trace from previous location ---
      System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Async(format: Pax, withContents: False) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(167,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
  nc(TarEntryFormat format, Boolean withContents)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(170,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
  nc(TarEntryFormat format, Boolean withContents)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(171,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
  nc(TarEntryFormat format, Boolean withContents)
          --- End of stack trace from previous location ---
      System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Async(format: Pax, withContents: True) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(167,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
  nc(TarEntryFormat format, Boolean withContents)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(170,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
  nc(TarEntryFormat format, Boolean withContents)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(171,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
  nc(TarEntryFormat format, Boolean withContents)
          --- End of stack trace from previous location ---
      System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Async(format: Gnu, withContents: False) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(167,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
  nc(TarEntryFormat format, Boolean withContents)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(170,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
  nc(TarEntryFormat format, Boolean withContents)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(171,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
  nc(TarEntryFormat format, Boolean withContents)
          --- End of stack trace from previous location ---
      System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Async(format: Gnu, withContents: True) [FAIL]
        Assert.Equal() Failure
        Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Actual:   OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
        Stack Trace:
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
  th, TarEntry entry)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(167,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
  nc(TarEntryFormat format, Boolean withContents)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(170,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
  nc(TarEntryFormat format, Boolean withContents)
          D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(171,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
  nc(TarEntryFormat format, Boolean withContents)
          --- End of stack trace from previous location ---
    Finished:    System.Formats.Tar.Tests
  === TEST EXECUTION SUMMARY ===
     System.Formats.Tar.Tests  Total: 755, Errors: 0, Failed: 44, Skipped: 0, Time: 0.736s
  ----- end 2022-08-08 11:50:38.30 ----- exit code 1 ----------------------------------------------------------

tmds · 2022-08-08T19:20:44Z

I applied the #72078 (comment), but then I ran the Windows tests and noticed they are failing with these errors:

There was a typo in the DefaultWindowsMode. It should be fixed now.

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHelpers.Unix.cs

carlossanlop · 2022-08-08T22:25:03Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-08-08T22:25:26Z

Azure Pipelines successfully started running 1 pipeline(s).

carlossanlop

@tmds I left a few more comments and also ran a runtime extra platforms job.

Co-authored-by: Carlos Sanchez <[email protected]>

carlossanlop · 2022-08-11T05:08:55Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-08-11T05:09:18Z

Azure Pipelines successfully started running 1 pipeline(s).

carlossanlop

LGTM. I'll merge it assuming the extra platforms CI legs don't show anything weird.

carlossanlop · 2022-08-12T14:53:51Z

Lots of unrelated failures, nothing on tar. Merging

Thank you @tmds for your help!

Tar: restore directory permissions while extracting.

2440cc3

dotnet-issue-labeler bot added the area-System.IO label Jul 13, 2022

ghost added the community-contribution Indicates that the PR has been added by a community member label Jul 13, 2022

tmds commented Jul 13, 2022

View reviewed changes

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHelpers.Unix.cs Outdated Show resolved Hide resolved

carlossanlop requested review from adamsitnik and carlossanlop July 13, 2022 07:04

carlossanlop added this to the 7.0.0 milestone Jul 13, 2022

runfoapp bot mentioned this pull request Jul 14, 2022

matrix4x4createfromaxisangletest failing on NativeAOT #72149

Closed

eerhardt reviewed Jul 14, 2022

View reviewed changes

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHelpers.Unix.cs Show resolved Hide resolved

eerhardt reviewed Jul 14, 2022

View reviewed changes

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHelpers.Unix.cs Show resolved Hide resolved

eerhardt reviewed Jul 14, 2022

View reviewed changes

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHelpers.Unix.cs Outdated Show resolved Hide resolved

eerhardt reviewed Jul 14, 2022

View reviewed changes

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHelpers.Unix.cs Outdated Show resolved Hide resolved