Using /unicode when running ildasm.exe roundtrip tests #71163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @directhex Issue DetailsShould resolve #70873 Description
|
|
@dotnet/jit-contrib this is ready. |
TIHan
force-pushed
the
ildasm-unicode-bug-fix
branch
from
4ad7f89 to
c500631
Compare
|
@dotnet/jit-contrib This is ready again. |
BruceForstall
approved these changes
Jul 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve #70873
Description
ILDASM was disassembling an assembly that had Unicode characters in it, but was not outputting them correctly. Adding the '/unicode' flag when running ILDASM fixes this.