Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][debugger] Enable onCallFrame evaluation of static fields in classes/interfaces from a static method. #70560

Merged
merged 11 commits into from
Jul 8, 2022
Merged

[wasm][debugger] Enable onCallFrame evaluation of static fields in classes/interfaces from a static method. #70560

merged 11 commits into from
Jul 8, 2022

Conversation

ilonatommy
Copy link
Member

Fixes #70135.

Read commit history to understand the changes.

Changes:

  • Adding prefix of current stack frame's namespace when trying to evaluate a static. This fixes among others: DIM problem where we did not see statics of the Interface from inside the DIM.
  • Structuring struct tests and renaming them, it was a bit messy before.

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels Jun 10, 2022
@ilonatommy ilonatommy added this to the 7.0.0 milestone Jun 10, 2022
@ilonatommy ilonatommy requested review from radical and thaystg June 10, 2022 13:31
@ilonatommy ilonatommy self-assigned this Jun 10, 2022
@ilonatommy ilonatommy requested a review from marek-safar as a code owner June 10, 2022 13:31
@ghost
Copy link

ghost commented Jun 10, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #70135.

Read commit history to understand the changes.

Changes:

  • Adding prefix of current stack frame's namespace when trying to evaluate a static. This fixes among others: DIM problem where we did not see statics of the Interface from inside the DIM.
  • Structuring struct tests and renaming them, it was a bit messy before.
Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-Debugger-mono
Milestone: 7.0.0

radical
radical previously requested changes Jun 21, 2022
View reviewed changes
@ghost ghost added needs-author-action An issue or pull request that requires more info or actions from the author. and removed needs-author-action An issue or pull request that requires more info or actions from the author. labels Jun 21, 2022
@ilonatommy
Copy link
Member Author

ilonatommy commented Jun 21, 2022 •
edited
Loading

Converting to draft till the PR won't be divided into: fixed errors in old test changes + new tests PR (here) and test refactoring to bundle them more nicely together in a separate PR.

ToDo in the follow-up PR:

  1. renaming tests so that they are easily understandable, EvaluateNonStaticClassWithStaticFields -> EvaluateStaticFieldsInInstanceClass, EvaluateStaticClass -> EvaluateStaticFieldsInStaticClass
  2. renaming test fields and props, this "1" at the end is not needed.
  3. bundling old tests and new tests from this PR and removing these that are duplicated.
  4. no changes to the code outside of tests.

@ilonatommy ilonatommy marked this pull request as draft June 21, 2022 17:03
@ilonatommy ilonatommy marked this pull request as ready for review June 24, 2022 14:58
@radical radical dismissed their stale review June 27, 2022 21:11

the PR has been updated since then

@ilonatommy ilonatommy merged commit 0ab2c1e into dotnet:main Jul 8, 2022
@ilonatommy ilonatommy mentioned this pull request Jul 8, 2022
Merged
ilonatommy added a commit that referenced this pull request Jul 19, 2022
@ilonatommy
[wasm][debugger] Removed duplicated testcases as a follow-up for #70560…
cd75ae1 
… (#71827)

* Renaming.

* Remoe duplicated testcases.

* Added missing awaits.

* Testing expressions with spaces, fixed indentation

* Applied @radical's comments.
@ghost ghost locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thaystg thaystg thaystg approved these changes

@radical radical radical left review comments

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees

@ilonatommy ilonatommy

Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

[wasm][debugger] Enable onCallFrame evaluation of static fields in classes/interfaces from a static method.
3 participants
@ilonatommy @radical @thaystg